You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general notarising the dmg is enough because stapling will be applied recursively if done right, so running xcnotary on the dmg once is sufficient. I'd also suggest always codesigning on macOS anyway in prep for Apple Silicon which would also allow the dmg generated for nightlies to be codesigned (and then just be thrown at the notarisation process on a tag event).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a new tag is created we now sign and notarize the osx build.
Motivation and Context
This should streamline making new releases
How Has This Been Tested?
Ran on staging branch, downloaded dmg and it was signed
Types of changes
Checklist: