allow for "linuxbrowser_source" to be controlled#360
Merged
Conversation
based on the request at bazukas/obs-linuxbrowser#46 I did a quick search for the string "browser_source" and these seem to be the only two occurrences. Enhancing the conditional with the identifier of the obs-linuxbrowser plugin, this should solve the problem. As I'm currently not at home, I can't verify this does what it should, but I will test it later tonight. @mjc666 if you are still interested please give it a test run to verify if these two plugins work together now.
Author
|
I compiled the plugin and installed it locally. I did not have enough time tonight to really try and control the linuxbrowser plugin from the websocket, but at least nothing broke by my change. |
Palakis
suggested changes
Aug 26, 2019
Palakis
approved these changes
Aug 26, 2019
Author
|
Thank you, @Palakis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on the request at bazukas/obs-linuxbrowser#46 I did a quick search for the string "browser_source" and these seem to be the only two occurrences. Enhancing the conditional with the identifier of the obs-linuxbrowser plugin, this should solve the problem.
As I'm currently not at home, I can't verify this does what it should, but I will test it later tonight.
@mjc666 if you are still interested please give it a test run to verify if these two plugins work together now.