Fix build on 5.3.0+trunk#9733
Merged
Merged
Conversation
Signed-off-by: Jan Midtgaard <mail@janmidtgaard.dk>
0a50815 to
f5c1373
Compare
dra27
reviewed
Jan 15, 2024
| @@ -1,3 +1,4 @@ | |||
| #define CAML_INTERNALS | |||
Member
There was a problem hiding this comment.
Might be worth commenting here that it's needed to access the functions in md5.h?
Signed-off-by: Jan Midtgaard <mail@janmidtgaard.dk>
97a1cfa to
818a6c3
Compare
emillon
approved these changes
Jan 15, 2024
emillon
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. #undef'ing CAML_INTERNALS does not work, anyway.
Collaborator
|
In terms of metadata, that probably means we'll have some versions to restrict in opam-repository but they don't claim compat with 5.3 anyway. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a recent change to the internal compiler headers,
duneno longer compiles ontrunk(named 5.3.0) on macOS.I spotted it since it is breaking out multicoretests CI run:
https://github.com/ocaml-multicore/multicoretests/actions/runs/7502879005/job/20426416884?pr=431#step:5:128
The fix is to
#define CAML_INTERNALSbefore loading any ocaml headers as documented in the OCaml manual:https://v2.ocaml.org/manual/intfc.html#ss:c-internals
CC to @dra27 who co-authored the PR