Brodcast module load event invoke multiple time.

[hlege]

Hi!

In "register" function get called with registerModules and didn't check the module is loaded or not.

e.g.:
angular.module("foo" , ["bar","bar2"]);

When it resolved the bar and bar2 is brodcasted , but when it resolve foo it call register function again
and broadcast bar and bar2 again.

I made a hot fix in line 680 with the following check:
if(regModules.indexOf(moduleName) !== -1) {
registerModules.pop();
continue;
}

[ocombe]

Hi, could you do me a plunkr with the bug in question so that I can check if your hotfix is the right solution ?

[hlege]

http://plnkr.co/edit/HjbEEigCaLrdqgR4JpZ6?p=preview
change the oclazyload_bug.js to oclazyload.js to see the fix.

Note: in the source code lot of ";" missed at the end of function.

[ocombe]

Thanks, I'll take a look at it this afternoon

[ocombe]

Ok I found the problem, we add the required modules foo, bar & bar2 to the "to-load" modules list, but then for each module we add also load the dependencies.
We will load in reverse order bar2 (no dependency), bar (no dependency), foo: 2 dependencies bar & bar2 that we will load again.
I need to make sure that we don't load those multiple times in the same loading batch.

The fix is a bit more complicated than your hot fix because we need to take into account that sometimes people want to reload the config/run functions of those modules.

I think that I know how to fix it but I have to make more test to be sure that I don't break anything. Anyway, thanks for the report ! I'll let you know once it's fixed.

[ocombe]

It's fixed in 0.3.7 !