async script and serie

[koryp]

Great module! Thank you!!!

I'm loading my custom angular module along with a few dependencies (specifically, jquery then a jq plugin) and so I'm using the serie config option to make sure jquery is ready for the plugin.

But, it appears the buildElement function always includes the async attribute for scripts and my jq plugin seems to be getting executed before jquery finishes loading.

I was able to fix this locally by changing line 111 from:
el.async = 1;
to:
el.async = (params.serie?0:1);

Alternatively, maybe the async attribute could be conditionally removed using a parameter in the load config...

Is this an appropriate fix or is there another approach using ocLazyLoad to avoid async scripts from executing out of sequence?

[ocombe]

Hmm that's weird because the serie param is supposed to make the lib wait for the script to have been effectively loaded (when the onload event has been called) to include the next script.
I'll take a look at this tonight, thanks !

[koryp]

I think the serie param is correctly waiting for the js file to load before proceeding to the next one.
But the async attribute on the script tag, as I understand it, allows DOM rendering to continue, including loading and processing other scripts.
Without the async attribute, scripts are loaded and fully executed before the browser proceeds to the next tag (script or otherwise).
So, my suspicion is that the jquery library is still being processed asynchronously and, in the meantime, the plugin was loaded and executed before jquery was fully initialized.

[ocombe]

Ah yes that would make sense !