Skip to content

Provide the loader with created elements#292

Merged
ocombe merged 3 commits into
ocombe:masterfrom
msak:master
Oct 13, 2016
Merged

Provide the loader with created elements#292
ocombe merged 3 commits into
ocombe:masterfrom
msak:master

Conversation

@msak

@msak msak commented Mar 11, 2016

Copy link
Copy Markdown
Contributor

Your loader decorators are very straight forward and can be overridden for custom purpose.
But I miss the possibility to get access to the elements created by buildElement.

It would be great if you could accept this request with my little change.

@ocombe

ocombe commented Mar 11, 2016

Copy link
Copy Markdown
Owner

Sure, could you change it in the sources instead of the dist folder please ?

@msak

msak commented Mar 11, 2016

Copy link
Copy Markdown
Contributor Author

Shame on me :)
Do you able to take the second commit from this pull request, or should I create a new one?

@ocombe

ocombe commented Mar 11, 2016

Copy link
Copy Markdown
Owner

If you add a commit to the same branch, it will be added to the PR (which is what you did).

@msak

msak commented Mar 11, 2016

Copy link
Copy Markdown
Contributor Author

So already done!

If you merge, when will be a new npm package created?

@ocombe

ocombe commented Mar 11, 2016

Copy link
Copy Markdown
Owner

I'll try to make a new release this week end.

@msak

msak commented Mar 11, 2016

Copy link
Copy Markdown
Contributor Author

Great! Thanks!

@msak

msak commented Mar 22, 2016

Copy link
Copy Markdown
Contributor Author

Hi Olivier, could you create a new npm package?

@kination

kination commented Sep 5, 2016

Copy link
Copy Markdown
Collaborator

Hello @msak . If it's okay, could you remove the changes on /dist files?

@ocombe

ocombe commented Sep 5, 2016

Copy link
Copy Markdown
Owner

they will be overwritten when you rebuild them anyway @djKooks

@kination

kination commented Sep 5, 2016

Copy link
Copy Markdown
Collaborator

Oh, okay. Just want to make sure.

@kination

Copy link
Copy Markdown
Collaborator

@ocombe It looks fine to merge this. How do you think?

@ocombe ocombe merged commit 3351e44 into ocombe:master Oct 13, 2016
@ocombe

ocombe commented Oct 13, 2016

Copy link
Copy Markdown
Owner

Yes :)

@ocombe

ocombe commented Feb 3, 2017

Copy link
Copy Markdown
Owner

I just released 1.1.0 with this, I think I did it right, I haven't published a new version on this repo for ages, let me know if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants