Draft
Conversation
|
|
added fist tale in ch-3 and security (permission rule for group) in ch-4 and start ch-5 , in that add views file
complete field, attribute , view in ch-5 and list and form in ch-6
mekav-odoo
force-pushed
the
19.0-tutorials-mekav
branch
from
c936ac4 to
6b0b9b8
Compare
mash-odoo
requested changes
Jan 2, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello @mekav-odoo,
Good work on the PR.
Please have a look at my comments and apply the needed changes.
mash-odoo
requested changes
Jan 8, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello,
Good Work going..
Here are some suggestions and questions..
estate/models/estate_property.py
Outdated
Comment on lines
40
to
43
| ("north", "North"), | ||
| ("south", "South"), | ||
| ("east", "East"), | ||
| ("west", "West"), |
mekav-odoo
force-pushed
the
19.0-tutorials-mekav
branch
from
4275261 to
9821fb8
Compare
implement statusbar widget, in List order model ordering & manual ordering and in form Attributes and options
add Attributes and options in List , default filter , filter domain in search and stat button
done implementation of model inheritance & view inheritance to display the list of properties linked to a salesperson directly in the Settings / Users form view and implemented ondelete() and create() functions.
mash-odoo
requested changes
Jan 16, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Good going on the task..
Here are a few questions and suggestions..
mekav-odoo
force-pushed
the
19.0-tutorials-mekav
branch
from
8950231 to
cf4ba1f
Compare
create new view 'kanban' , added some permanent fields and conditional visible fields, set attributes for grouped properties by type by default
…onents Added reactive Counter component with props and callbacks Extracted reusable sub-components and implemented props validation Implemented Card component with markup support and slots Built TodoList and TodoItem components with add, toggle, and delete features Used Owl hooks, refs, dynamic attributes, and lifecycle patterns
Use Layout component with control panel Add quick navigation buttons (Customers, Leads) Add dashboard item component with responsive sizing Fetch and display statistics via rpc From ch-2 of web framework
… to 8) Add statistics service with memoized rpc calls Periodically refresh statistics using reactive state Display sales distribution using a Chart.js pie chart Lazy load dashboard assets using LazyComponent
mash-odoo
requested changes
Feb 5, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Thank you for your work..
And good progress overall..
Here are some questions and comments!
|
|
||
| name = fields.Char(required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() |
There was a problem hiding this comment.
Do we really need the Char datatype here?
| id="property_mail_send_primary" | ||
| name="action_sold_mail_send" | ||
| type="object" | ||
| context="{'validate_analytic': True, 'check_document_layout': True}" |
| type="object" | ||
| context="{'validate_analytic': True, 'check_document_layout': True}" | ||
| class="btn-primary" | ||
| data-hotkey="g" |
| </div> | ||
| <div class="text-muted"> | ||
| <div>Expected Price:<field name="expected_price"/></div> | ||
| <div t-if="record.state.raw_value == 'offer_received'">Best Offer:<field name="best_price"/></div> |
| <field name="name">Estate Property: Sold Confirmation</field> | ||
| <field name="model_id" ref="estate.model_estate_property"/> | ||
| <field name="subject">Offer Accepted: {{ object.name }}</field> | ||
|
|
There was a problem hiding this comment.
Suggested change
You can remove unnecessary spaces from the entire file and keep a clean file
… 9 & 10) - Defining a standard structure for dashboard items (NumberCard and PieChartCard). - Updating the dashboard template to use a t-foreach loop with dynamic Owl components (t-component) and props. - Implementing a registry-based system to manage these items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module: Estate
Initialized the estate module for Odoo Technical Training. This includes the base model definitions, security access rights, and the initial user interface as outlined in the tutorial steps.