Skip to content

Conversation

@jakan-odoo
Copy link

Chapter 4 is completed in this update.

Basic security access rules are added for the Estate module so users can access records correctly. Code style issues like missing white space and formatting problems are also fixed.

- Real Estate module created
- Basic structure and required fields added
- CHAPTER 1, 2, and 3
- Added basic security access for estate records
- Fixed missing whitespace and formatting issues
- Covers CHAPTER 4
@robodoo
Copy link

robodoo commented Jan 1, 2026

Pull request status dashboard

- Added form and list views for estate records
- Added menu and action to access the module
- Covers CHAPTER 5
- Added list, form, and search views
- Added domains and group by options
- Covers CHAPTER 6
Copy link

@mash-odoo mash-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jakan-odoo,
Good start on the PR,
Please view the comments and apply the needed changes.

Comment on lines 1 to 2
from odoo import fields, models
from dateutil.relativedelta import relativedelta

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 9 to 10
<record id="estate_property_list_view" model="ir.ui.view">
<field name="name">estate.property.list</field>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For naming a view: <model_name>_view_<view_type>, where view_type is kanban, form, list, search, …
You can refer this guideline: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming

Comment on lines 25 to 26
<record id="estate_property_form_view" model="ir.ui.view">
<field name="name">estate.property.form</field>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do same as suggested above

- Added Many2one relation between models
- Improves data linking between records
- Covers CHAPTER 7
- Added One2many and Many2many relations between models
- Improves linking and management of related records
- Covers CHAPTER 7
- Added computed fields for automatic values
- Added onchange methods to update fields
- Covers CHAPTER 8
- Created Sell, Cancel, Accept, and Refuse buttons
- Buttons call related methods on the estate models
- Buyer and selling price are set when an offer is accepted
- Covers CHAPTER 9
Copy link

@mash-odoo mash-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Good going on the task..
Here are some suggestions..

<field name="bedrooms"/>
<field name="living_area"/>
<field name="selling_price"/>
<filter string="Available Properties" name="available properties" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write this filter in any other way?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ma'am,
We can write filter like this
<filter string="Available Properties" name="available_properties" domain="[('state', 'in', ('new', 'offer_received'))]"/>

</form>
</field>
</record>
</odoo> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a line at the end of file

Comment on lines 31 to 34
("north", "North"),
("south", "South"),
("east", "East"),
("west", "West")])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("north", "North"),
("south", "South"),
("east", "East"),
("west", "West")])
('north', "North"),
('south', "South"),
('east', "East"),
('west', "West")])

Comment on lines 38 to 42
('new', 'New'),
('offer_received', 'Offer Received'),
('offer_accepted', 'Offer Accepted'),
('sold', 'Sold'),
('cancelled', 'Cancelled'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
('new', 'New'),
('offer_received', 'Offer Received'),
('offer_accepted', 'Offer Accepted'),
('sold', 'Sold'),
('cancelled', 'Cancelled'),
('new', "New"),
('offer_received', "Offer Received"),
('offer_accepted', "Offer Accepted"),
('sold', "Sold"),
('cancelled', '"Cancelled"),

@@ -0,0 +1,20 @@
{
'name': 'Real Estate',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'name': 'Real Estate',
'name': "Real Estate",

'version': '1.0',
'category': 'Real Estate',
'summary': 'Manage real estate properties',
'description': 'This module allows managing properties.',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'description': 'This module allows managing properties.',
'description': "This module allows managing properties.",

Comment on lines +1 to +2
from dateutil.relativedelta import relativedelta
from odoo import fields, models, api

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Added SQL constraints to ensure data validity
- Added Python constraints for business rules
- Covers CHAPTER 10
- Added inline views for related records
- Applied widgets to improve user interface
- Set default ordering using _order
- CHAPTER 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants