Ethereum setDifficulty not working

[yq0810]

Describe the bug

this way context.ApplyPendingDifficulty() alway false, NotifyAsync SetDifficulty will never happen.

miningcore/src/Miningcore/Blockchain/Ethereum/EthereumPool.cs

Line 247 in 8d40733

if(context.ApplyPendingDifficulty())

Because the pending has been set to null here with

miningcore/src/Miningcore/Blockchain/Ethereum/EthereumPool.cs

Line 536 in 8d40733

if(context.ApplyPendingDifficulty())

[oliverw]

No correct. This is not the only place where SendJob gets called.

miningcore/src/Miningcore/Blockchain/Ethereum/EthereumPool.cs

Line 437 in 8d40733

await SendJob(context, connection, currentJobParams);

[yq0810]

miningcore/src/Miningcore/Blockchain/Ethereum/EthereumPool.cs

Lines 530 to 549 in 2e3a0f1

	protected override async Task OnVarDiffUpdateAsync(StratumConnection connection, double newDiff, CancellationToken ct)
	{
	await base.OnVarDiffUpdateAsync(connection, newDiff, ct);
	var context = connection.ContextAs<EthereumWorkerContext>();
	if(context.ApplyPendingDifficulty())
	{
	switch(context.ProtocolVersion)
	{
	case 1:
	await SendWork(context, connection, 0);
	break;
	case 2:
	await SendJob(context, connection, manager.GetJobParamsForStratum());
	break;
	}
	}
	}

OnVarDiffUpdateAsync fucntion called if ApplyPendingDifficulty == true, when the difficulty changes, he will set him to null, but does nothing, and then SendJob can't get ApplyPendingDifficulty == true

remove it (L530-L549), it works.

[yq0810]

This can be fix
#1342

[oliverw]

I stand corrected. Thanks @yq0810