DICOM: use Study Time tag as an extra check on whether files should be grouped
#4354
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerring
reviewed
Oct 7, 2025
|
|
||
| if (date.equals(originalDate) && (Math.abs(stamp - timestamp) < 150000000)) { | ||
| double timeDifference = Math.abs(stamp - timestamp); | ||
| LOGGER.trace(" time difference (microsecs) = {}", timeDifference); |
There was a problem hiding this comment.
Very minor point but is it worth taking the abs after the log so that direction is preserved in the log?
Member
There was a problem hiding this comment.
I would be inclined to keep things as they are:
- the conditional check is made on the absolute difference between the two timestamps
- the new logging statement essentially prints this absolute difference at the TRACE level
- the values of the individual timestamps are also logged at the TRACE level above
For debugging purposes, it should be possible to deduce the direction of the difference using this combination of values if desired
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/qupath-closing-with-40x-dicom-layer/117202/6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out a less restrictive check on timestamps for file grouping, intended to help with WSI data.
Mostly opening to check for test failures at this point, anticipating that some refinement may be needed.