feat: typescript definitions and runner update#2
Open
teunmooij wants to merge 2 commits intoonebeyond:masterfrom
Open
feat: typescript definitions and runner update#2teunmooij wants to merge 2 commits intoonebeyond:masterfrom
teunmooij wants to merge 2 commits intoonebeyond:masterfrom
Conversation
Collaborator
|
Thanks @teunmooij. I'll review shortly |
Author
|
@cressie176 friendly reminder |
Author
|
@cressie176 is there still a chance this can get merged? |
cressie176
reviewed
Feb 14, 2023
Collaborator
cressie176
left a comment
cressie176
left a comment
There was a problem hiding this comment.
Looks fine. Could use a line break at the bottom of the file, but no biggie
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added typescript type definitions
Updated default runner (service-runner) dependency to latest version of that package
Since this package doesn't seem to have a CI/CD pipeline in place, I've manually updated the package version. Because service-runner had a major version bump, I thought made sense to also make this one major.