Preserve selectedStartDate in state on props update#239
Open
wheywu wants to merge 1 commit intoonefinestay:masterfrom
Open
Preserve selectedStartDate in state on props update#239wheywu wants to merge 1 commit intoonefinestay:masterfrom
wheywu wants to merge 1 commit intoonefinestay:masterfrom
Conversation
Currently, in `componentWillReceiveProps`, we always set `selectedStartDate` to be null. This can lead to buggy behavior when selectedStartDate was already set to something, as alluded to in these issues: onefinestay#224 onefinestay#203 This issue will arise when the onSelectStart callback in the parent component does something that leads to changes in prop values passed into <DateRangePicker>, which will lead to `selectedStartDate` in state to be reset. Keeping selectedStartDate whatever value it was in componentWillReceiveProps will fix this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in
componentWillReceiveProps, we always setselectedStartDateto be null. This can lead to buggy behavior when selectedStartDate was already set to something, as alluded to in these issues:#224
#203
This issue will arise when the onSelectStart callback in the parent component does something that leads to changes in prop values passed into , which will lead to
selectedStartDatein state to be reset. Keeping selectedStartDate whatever value it was in componentWillReceiveProps will fix this issue.