fix: ignoredRouteFiles should also ignore type generation#596
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the ignoredRouteFiles configuration was not being respected during TypeScript type generation for file system routes. The change ensures that ignored route files are also excluded when generating route types.
- Modified the
generateRouteTypesfunction to accept and use theignoredRouteFilesparameter - Updated plugin calls to pass the ignored route files configuration to the type generation function
- Added filtering logic using micromatch to exclude ignored routes from type generation
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/one/src/vite/plugins/generateFileSystemRouteTypesPlugin.tsx | Updated plugin to pass ignoredRouteFiles to generateRouteTypes function |
| packages/one/src/typed-routes/generateRouteTypes.ts | Added ignoredRouteFiles parameter and filtering logic using micromatch |
| tests/CLAUDE.md | Added reference to test instructions |
| CLAUDE.md | Added reference to general instructions |
| .github/instructions/tests.instructions.md | Added documentation for tests directory structure |
| .github/instructions/general.instructions.md | Added project overview and monorepo structure documentation |
| .github/copilot-instructions.md | Added reference to general instructions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.