Skip to content

Refactor jobqueue to require initialized progress consumer#7971

Closed
peterargue wants to merge 5 commits intomasterfrom
peter/refactor-component-consumers
Closed

Refactor jobqueue to require initialized progress consumer#7971
peterargue wants to merge 5 commits intomasterfrom
peter/refactor-component-consumers

Conversation

@peterargue
Copy link
Contributor

@peterargue peterargue commented Sep 26, 2025

The existing logic requires an storage.ConsumerProgressInitializer and a default value, then calls Initialize() in the constructor. This means that all data must be available at construction. Since the data is already available, let's do the initialization within the bootstrap, and pass in the completed object. I find this to be a more logical flow, and allows access to the ConsumerProgress earlier in the process so it can be queried to initialize other state within the components.

@peterargue peterargue requested a review from a team as a code owner September 26, 2025 17:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Dec 14, 2025
@peterargue peterargue added Preserve Stale Bot repellent and removed Stale Label used when marking an issue stale. labels Dec 15, 2025
@peterargue
Copy link
Contributor Author

close in favor of #8404

@peterargue peterargue closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preserve Stale Bot repellent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants