Skip to content

Suggested amendments for PR 7918#8138

Merged
durkmurder merged 2 commits intoyurii/6127-vote-double-countingfrom
alex/6127-vote-double-counting_-_suggestions
Nov 20, 2025
Merged

Suggested amendments for PR 7918#8138
durkmurder merged 2 commits intoyurii/6127-vote-double-countingfrom
alex/6127-vote-double-counting_-_suggestions

Conversation

@AlexHentschel
Copy link
Member

@AlexHentschel AlexHentschel commented Nov 12, 2025

This PR has documentation revisions only, which I would suggest to include in #7918.

If you can spare the time, it would be great if you could take a detailed look at the VoteCollector, specifically:

  • This proof showing that we never miss votes (essentially a liveness proof). You didn't change anything in this regard and the code seemed plausibly correct. However, it took me some time to refresh my memory and convince myself that it is in fact correct. Therefore, I thought it would be good to document the liveness argument more formally inside the code.
  • This documentation explains how we distribute the responsibility of detecting equivocation attacks and double-counting attacks.

Please take a critical look, whether my suggested documentation revisions (especially the proof and explaining the responsibility of detecting equivocation) are clear and can be followed.

@durkmurder durkmurder merged commit 21feb67 into yurii/6127-vote-double-counting Nov 20, 2025
@durkmurder durkmurder deleted the alex/6127-vote-double-counting_-_suggestions branch November 20, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants