Suggested amendments for PR 7918#8138
Merged
durkmurder merged 2 commits intoyurii/6127-vote-double-countingfrom Nov 20, 2025
Merged
Suggested amendments for PR 7918#8138durkmurder merged 2 commits intoyurii/6127-vote-double-countingfrom
durkmurder merged 2 commits intoyurii/6127-vote-double-countingfrom
Conversation
…onflow/flow-go into alex/6127-vote-double-counting_-_suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has documentation revisions only, which I would suggest to include in #7918.
If you can spare the time, it would be great if you could take a detailed look at the
VoteCollector, specifically:Please take a critical look, whether my suggested documentation revisions (especially the proof and explaining the responsibility of detecting equivocation) are clear and can be followed.