[Benchmark] Fix benchmark manual cmd#8153
Merged
zhangchiqing merged 4 commits intomasterfrom Nov 19, 2025
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
zhangchiqing
commented
Nov 14, 2025
Comment on lines
+83
to
84
| server.Start(signalerCtx) | ||
| <-server.Ready() |
Member
Author
There was a problem hiding this comment.
It was stuck on <-server.Ready because server.Start was not called.
zhangchiqing
requested review from
fxamacker,
janezpodhostnik and
peterargue
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jordanschalm
approved these changes
Nov 14, 2025
Comment on lines
+71
to
+75
| case err, ok := <-errChan: | ||
| if !ok { | ||
| // Channel was closed without an error (shouldn't happen, but handle gracefully) | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| case err, ok := <-errChan: | |
| if !ok { | |
| // Channel was closed without an error (shouldn't happen, but handle gracefully) | |
| return | |
| } | |
| case err := <-errChan: |
Feel free to keep for clarity, but I don't think this clause is necessary. (If ok=false, then err=nil)
Co-authored-by: Jordan Schalm <jordan.schalm@flowfoundation.org>
fxamacker
approved these changes
Nov 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the local benchmark util. It gets stuck on metrics server.Ready at the beginning, because the server was not started.