Skip to content

[v0.44] Allow transactions authorized by restricted account but payed by service account#8275

Merged
turbolent merged 7 commits intov0.44from
bastian/account-restriction-exception-for-service-account
Dec 29, 2025
Merged

[v0.44] Allow transactions authorized by restricted account but payed by service account#8275
turbolent merged 7 commits intov0.44from
bastian/account-restriction-exception-for-service-account

Conversation

@turbolent
Copy link
Member

@turbolent turbolent requested a review from a team as a code owner December 29, 2025 00:43
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left some suggestions.

@janezpodhostnik
Copy link
Contributor

I made some changes. I was making them with a rolling deploy in mind. This should be safe to deploy with a rolling deploy under 2 conditions.

  • the service account should not interact with any restricted accounts during the rolling deploy.
  • we should check the system transactions are not failing due to a restricted account.

otherwise we risk a fork.

@janezpodhostnik janezpodhostnik force-pushed the bastian/account-restriction-exception-for-service-account branch from 4980908 to bf29672 Compare December 29, 2025 16:44
Copy link
Member Author

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! (Can't approve my own PR)

Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left a minor suggestion.

@zhangchiqing zhangchiqing reopened this Dec 29, 2025
@turbolent turbolent merged commit feb5842 into v0.44 Dec 29, 2025
225 of 228 checks passed
@turbolent turbolent deleted the bastian/account-restriction-exception-for-service-account branch December 29, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants