Skip to content

port AN compatibility changes to master#8319

Merged
j1010001 merged 1 commit intomasterfrom
jan/port-v0.44-access-compatibility
Jan 8, 2026
Merged

port AN compatibility changes to master#8319
j1010001 merged 1 commit intomasterfrom
jan/port-v0.44-access-compatibility

Conversation

@j1010001
Copy link
Member

@j1010001 j1010001 commented Jan 8, 2026

port to master:

#8281
#8284
#8289
#8292
https://github.com/onflow/flow-go-internal/pull/7139

Summary by CodeRabbit

  • Chores
    • Updated version compatibility handling for versions 0.44.7, 0.44.10, 0.44.14, 0.44.15, 0.44.16, 0.44.17, and 0.44.18 to ensure improved system stability and compatibility management.

✏️ Tip: You can customize this high-level summary in your review settings.

@j1010001 j1010001 requested a review from a team as a code owner January 8, 2026 22:36
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

Added seven new entries to the version compatibility overrides map in version control, marking versions 0.44.7 through 0.44.18 as compatibility overrides to be ignored during version beacon processing.

Changes

Cohort / File(s) Summary
Version Compatibility Overrides
engine/common/version/version_control.go
Added seven new version entries (0.44.7, 0.44.10, 0.44.14, 0.44.15, 0.44.16, 0.44.17, 0.44.18) to defaultCompatibilityOverrides map

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Seven versions hop into the map,
With overrides tucked under their cap,
Beacons won't trouble these versions so fine,
All lined up in perfect design! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'port AN compatibility changes to master' directly describes the main objective of the PR—porting compatibility changes to the master branch, which aligns with the actual changes (adding compatibility override entries).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a828cf6 and b4d905b.

📒 Files selected for processing (1)
  • engine/common/version/version_control.go
🧰 Additional context used
📓 Path-based instructions (4)
**/*.go

📄 CodeRabbit inference engine (.cursor/rules/coding_conventions.mdc)

Follow Go coding conventions as documented in @docs/agents/CodingConventions.md

Follow Go coding standards and conventions as documented in @docs/agents/GoDocs.md

**/*.go: Follow the existing module structure in /module/, /engine/, /model/ and use dependency injection patterns for component composition
Implement proper interfaces before concrete types
Follow Go naming conventions and the project's coding style defined in /docs/CodingConventions.md
Use mock generators: run make generate-mocks after interface changes
All inputs must be considered potentially byzantine; error classification is context-dependent and no code path is safe unless explicitly proven and documented
Use comprehensive error wrapping for debugging; avoid fmt.Errorf, use irrecoverable package for exceptions
NEVER log and continue on best effort basis; ALWAYS explicitly handle errors
Uses golangci-lint with custom configurations (.golangci.yml) and custom linters for Flow-specific conventions (struct write checking)

Files:

  • engine/common/version/version_control.go
{module,engine,cmd}/**/*.go

📄 CodeRabbit inference engine (AGENTS.md)

All major processing components must implement the Component interface from /module/component/component.go to ensure consistent lifecycle management and graceful shutdown patterns

Files:

  • engine/common/version/version_control.go
{crypto,fvm,ledger,access,engine}/**/*.go

📄 CodeRabbit inference engine (AGENTS.md)

Cryptographic operations require careful handling; refer to crypto library documentation for proper implementation

Files:

  • engine/common/version/version_control.go
{network,engine,consensus}/**/*.go

📄 CodeRabbit inference engine (AGENTS.md)

Network messages must be authenticated and validated

Files:

  • engine/common/version/version_control.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (37)
  • GitHub Check: Lint (./integration/)
  • GitHub Check: Lint (./)
  • GitHub Check: Lint (./insecure/)
  • GitHub Check: Unit Tests (network/p2p/scoring)
  • GitHub Check: Unit Tests (network/p2p)
  • GitHub Check: Unit Tests (network/alsp)
  • GitHub Check: Unit Tests (engine/collection)
  • GitHub Check: Unit Tests (network)
  • GitHub Check: Unit Tests (engine/execution)
  • GitHub Check: Unit Tests (module)
  • GitHub Check: Unit Tests (engine/verification)
  • GitHub Check: Unit Tests (network/p2p/connection)
  • GitHub Check: Unit Tests (engine/access)
  • GitHub Check: Unit Tests (network/p2p/node)
  • GitHub Check: Unit Tests (engine/execution/computation)
  • GitHub Check: Unit Tests (engine)
  • GitHub Check: Unit Tests (network/test/cohort1)
  • GitHub Check: Unit Tests (others)
  • GitHub Check: Unit Tests (network/test/cohort2)
  • GitHub Check: Unit Tests (engine/execution/ingestion)
  • GitHub Check: Unit Tests (module/dkg)
  • GitHub Check: Unit Tests (consensus)
  • GitHub Check: Unit Tests (cmd)
  • GitHub Check: Unit Tests (fvm)
  • GitHub Check: Unit Tests (engine/consensus)
  • GitHub Check: Unit Tests (utils)
  • GitHub Check: Unit Tests (admin)
  • GitHub Check: Unit Tests (ledger)
  • GitHub Check: Unit Tests (engine/common)
  • GitHub Check: Unit Tests (storage)
  • GitHub Check: Unit Tests (state)
  • GitHub Check: Unit Tests Insecure (insecure/integration/functional/test/gossipsub/scoring)
  • GitHub Check: Unit Tests Insecure (insecure)
  • GitHub Check: Unit Tests Insecure (insecure/integration/functional/test/gossipsub/rpc_inspector)
  • GitHub Check: Integration Tests Others (integration)
  • GitHub Check: Docker Build
  • GitHub Check: analyze-code (go)
🔇 Additional comments (1)
engine/common/version/version_control.go (1)

59-65: Compatibility overrides added correctly and properly ordered.

The seven new version entries (0.44.7 through 0.44.18) are correctly formatted, properly sequenced in ascending order, and match the existing pattern. The backwards compatibility requirement noted in the IMPORTANT comment (lines 38-39) applies to these additions, ensuring only HCU versions with backwards-compatible cadence and fvm changes are included.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@j1010001 j1010001 merged commit 52b03a8 into master Jan 8, 2026
61 checks passed
@j1010001 j1010001 deleted the jan/port-v0.44-access-compatibility branch January 8, 2026 23:05
@coderabbitai coderabbitai bot mentioned this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants