Skip to content

Revert: Add service account override#8324

Merged
janezpodhostnik merged 4 commits intov0.44from
janez/revert-add-service-account-override
Jan 13, 2026
Merged

Revert: Add service account override#8324
janezpodhostnik merged 4 commits intov0.44from
janez/revert-add-service-account-override

Conversation

@janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Jan 12, 2026

reverts: #8273

@janezpodhostnik janezpodhostnik self-assigned this Jan 12, 2026
@janezpodhostnik janezpodhostnik requested a review from a team as a code owner January 12, 2026 18:01
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

zhangchiqing
zhangchiqing reviewed Jan 12, 2026
View reviewed changes
fvm/transactionVerifier.go Outdated
address flow.Address,
keyWeightThreshold int,
) bool {
fmt.Println(weights[address], keyWeightThreshold)
Copy link
Member

@zhangchiqing zhangchiqing Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we keep this?

Copy link
Contributor Author

@janezpodhostnik janezpodhostnik Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it and re-added a comment higher up.

@janezpodhostnik janezpodhostnik merged commit a2396c5 into v0.44 Jan 13, 2026
57 checks passed
@janezpodhostnik janezpodhostnik deleted the janez/revert-add-service-account-override branch January 13, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@fxamacker fxamacker fxamacker approved these changes

@holyfuchs holyfuchs Awaiting requested review from holyfuchs

@peterargue peterargue Awaiting requested review from peterargue

Assignees

@janezpodhostnik janezpodhostnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janezpodhostnik @codecov-commenter @zhangchiqing @fxamacker