Skip to content

Remove unused revive#8387

Merged
janezpodhostnik merged 1 commit intomasterfrom
janez/clean-revive
Feb 3, 2026
Merged

Remove unused revive#8387
janezpodhostnik merged 1 commit intomasterfrom
janez/clean-revive

Conversation

@janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Feb 3, 2026

... it was commented out 4 years ago.

Summary by CodeRabbit

  • Chores
    • Removed commented-out linting commands from build configuration files
    • Removed a linting configuration file

@janezpodhostnik janezpodhostnik requested a review from a team February 3, 2026 19:52
@janezpodhostnik janezpodhostnik self-assigned this Feb 3, 2026
@janezpodhostnik janezpodhostnik requested a review from a team as a code owner February 3, 2026 19:52
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The pull request removes the revive linting tool from the project's build pipeline by deleting the revive.toml configuration file and removing commented revive commands from Makefiles. No functional code changes are affected.

Changes

Cohort / File(s) Summary
Build Configuration
Makefile, insecure/Makefile
Removed commented revive linter commands from lint and fix-lint targets; lint commands remain functional.
Linting Configuration
revive.toml
Removed entire revive linter configuration file that defined global settings and 20+ rule configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Revive, revive, thy warnings fade,
Config and comments—all unmade,
Lint rules swept away with care,
Cleaner builds now fill the air!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove unused revive' accurately summarizes the main change: removing the revive linter configuration and related commented-out commands from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch janez/clean-revive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@janezpodhostnik janezpodhostnik requested a review from a team February 3, 2026 20:19
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Feb 3, 2026
Merged via the queue into master with commit e3f8ef4 Feb 3, 2026
61 checks passed
@janezpodhostnik janezpodhostnik deleted the janez/clean-revive branch February 3, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants