Conversation
No longer necessary since go 1.22, see https://go.dev/wiki/LoopvarExperiment
The loop variable assigned by a range statement inherits the type of the
variable used to create the range, including signedness, so in
```
for i := range X { ... }
```
`i` has the same integer type as `X`.
slices package was introduced in go 1.21
|
Important Review skippedToo many files! This PR contains 185 files, which is 35 over the limit of 150. You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
tim-barry
requested review from
janezpodhostnik,
jordanschalm and
zhangchiqing
|
@tarakby I'm not sure if we want to automatically run go fix because I'm not sure yet that we will want all the fixes. For now I think we can add it, and revisit the decision when we actually upgrade to go 1.26. |
4 participants
This PR applies several (not all) fixers from go 1.26. Note the repository still uses go version 1.25.1 - all the fixes were checked to be compatible. See individual commits for more info about specific fix types.
It also adds a
go-fixMakefile step which is run as part of CI (which currently only runs the fixers available in go1.25, as that is the go version currently used by the repository).Fixers run: