fix: ensure zero_grad is called before backward in Autoencoder._learn#116
Merged
kulbachcedric merged 1 commit intoonline-ml:masterfrom May 22, 2025
Merged
fix: ensure zero_grad is called before backward in Autoencoder._learn#116kulbachcedric merged 1 commit intoonline-ml:masterfrom
kulbachcedric merged 1 commit intoonline-ml:masterfrom
Conversation
Collaborator
|
Hi @GoBeromsu, Best, |
Contributor
Author
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the interesting project. While reviewing the code, I discovered a gradient management issue specific to the
Autoencoder._learnmethod.Initially, I thought the current gradient update sequence might be a deliberate design pattern. However, after inspecting other components, I found that all other learning processes follow the correct PyTorch order:
zero_grad()→backward()→step().In contrast, the
Autoencodercurrently performs:backward()→step()→zero_grad(),which can cause gradient leakage if an exception is raised between
backward()andzero_grad().Test code