Skip to content

Added docker compose example for AgentQnA deployment on AMD ROCm #1166

Merged
chensuyue merged 2 commits intoopea-project:mainfrom
artem-astafev:feature/add-compose-AgentQnA-example-for-amd-rocm
Dec 18, 2024
Merged

Added docker compose example for AgentQnA deployment on AMD ROCm #1166
chensuyue merged 2 commits intoopea-project:mainfrom
artem-astafev:feature/add-compose-AgentQnA-example-for-amd-rocm

Conversation

@artem-astafev
Copy link
Contributor

@artem-astafev artem-astafev commented Nov 20, 2024

Type of change

  • Added docker compose example for AgentQnA deployment on AMD ROCm (TGI service is in use).
  • Added CI tests for Docker compose AgentQnA deploymen example on AMD ROCm systems

Tests

Go to GenAIExamples/AgentQnA/tests and run test_compose_on_rocm.sh bash script (./test_compose_on_rocm.sh).

@joshuayao joshuayao linked an issue Nov 21, 2024 that may be closed by this pull request
[Feature] Examples on AMD ROCm for OPEA v1.2 #1178
Closed
5 tasks
@joshuayao joshuayao mentioned this pull request Nov 21, 2024
Closed
5 tasks
dcmiddle
dcmiddle reviewed Dec 6, 2024
View reviewed changes
dcmiddle
dcmiddle reviewed Dec 6, 2024
View reviewed changes
@dcmiddle
Copy link
Contributor

dcmiddle commented Dec 6, 2024

please squash your fixup commits

@artem-astafev
Copy link
Contributor Author

artem-astafev commented Dec 13, 2024

@dcmiddle

please squash your fixup commits

Is it necessary? If I understand write all commits will be squashed after merge.

@dcmiddle
Copy link
Contributor

dcmiddle commented Dec 13, 2024

@dcmiddle

please squash your fixup commits

Is it necessary? If I understand write all commits will be squashed after merge.

Yes please.
The goal is to arrive at a commit message that explains why a change was made. When the commit history is littered with fixup comments it makes it harder for people to understand the code using tools like git blame.

@artem-astafev artem-astafev force-pushed the feature/add-compose-AgentQnA-example-for-amd-rocm branch 4 times, most recently from 6d20e47 to 26a329f Compare December 16, 2024 09:27
@artem-astafev
Added docker compose example for AMD ROCm deployment
4b1a924 
Signed-off-by: artem-astafev <a.astafev@datamonsters.com>
@artem-astafev artem-astafev force-pushed the feature/add-compose-AgentQnA-example-for-amd-rocm branch from 030eb17 to 4b1a924 Compare December 16, 2024 09:37
@artem-astafev
Copy link
Contributor Author

artem-astafev commented Dec 16, 2024

@dcmiddle

please squash your fixup commits

Is it necessary? If I understand write all commits will be squashed after merge.

Yes please. The goal is to arrive at a commit message that explains why a change was made. When the commit history is littered with fixup comments it makes it harder for people to understand the code using tools like git blame.

@dcmiddle Done, I've squash all changes into one commit.

dcmiddle
dcmiddle approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@dcmiddle dcmiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. thanks for the extra cleanup.

@chensuyue chensuyue merged commit df7c192 into opea-project:main Dec 18, 2024
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Dec 20, 2024
@artem-astafev
Added docker compose example for AgentQnA deployment on AMD ROCm (ope…
379ff0b 
…a-project#1166)

Signed-off-by: artem-astafev <a.astafev@datamonsters.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
@artem-astafev @cogniware-devops
Added docker compose example for AgentQnA deployment on AMD ROCm (ope…
df122c0 
…a-project#1166)

Signed-off-by: artem-astafev <a.astafev@datamonsters.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chensuyue chensuyue chensuyue approved these changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

+1 more reviewer

@dcmiddle dcmiddle dcmiddle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Examples on AMD ROCm for OPEA v1.2

4 participants

@artem-astafev @dcmiddle @chensuyue @lvliang-intel