feat: remove node 16#875
Merged
Merged
Conversation
beeme1mr
reviewed
Mar 14, 2024
toddbaert
approved these changes
Mar 15, 2024
toddbaert
requested changes
Mar 15, 2024
Member
There was a problem hiding this comment.
Blocking this as per discussion with @lukas-reining @beeme1mr . We will have to decide on stability guarantees with EOL runtime versions.
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
toddbaert
force-pushed
the
chore/remove-node-16
branch
from
dc22268 to
a18aa91
Compare
Member
|
I'll be merging this today, consistent with our guidelines here. The TC met about this issue and concluded that since this is a relatively new library and since Node 16 is well beyond its EOL, we will merge this and consider it a non-breaking change. I will add some copy in the release notes about it. |
toddbaert
approved these changes
May 13, 2024
This was referenced May 13, 2024
toddbaert
added a commit
that referenced
this pull request
May 13, 2024
🤖 I have created a release *beep* *boop* --- ## [1.14.0](server-sdk-v1.13.5...server-sdk-v1.14.0) (2024-05-13) ### 🐛 Bug Fixes * remove export of OpenFeatureClient ([#794](#794)) ([3d197f2](3d197f2)) * removes exports of OpenFeatureClient class and makes event props readonly ([#918](#918)) ([e9a25c2](e9a25c2)) * run error hook when provider returns reason error or error code ([#926](#926)) ([c6d0b5d](c6d0b5d)) ### 🧹 Chore * remove node 16 ([#875](#875)) ([c1878e4](c1878e4)) * **main:** release core 1.2.0 ([#927](#927)) ([692ad5b](692ad5b)) ### 📚 Documentation * add tip about supported usage in the install section ([#941](#941)) ([f0de667](f0de667)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
added a commit
that referenced
this pull request
May 13, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.5-experimental](nestjs-sdk-v0.1.4-experimental...nestjs-sdk-v0.1.5-experimental) (2024-05-13) ### 🐛 Bug Fixes * removes exports of OpenFeatureClient class and makes event props readonly ([#918](#918)) ([e9a25c2](e9a25c2)) ### 🧹 Chore * remove node 16 ([#875](#875)) ([c1878e4](c1878e4)) * **deps:** update dependency supertest to v7 ([#939](#939)) ([9083df8](9083df8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Removes Node 16 as it is deprecated.