Conversation
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
- Add open-feature-ofrep as dependency to flagd - Update rest feature to use open-feature-ofrep - Add cert_path option to OfrepOptions for TLS support Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren_atas@hotmail.com>
Signed-off-by: Eren Atas <eren.atas@booking.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates a significant restructuring of the Rust cargo workspace, separating certain crates for independent release management. Concurrently, it refactors the Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully restructures the Cargo workspace by separating env-var, flipt, and flagsmith crates into a standalone release configuration. This improves modularity and clarifies dependency management. A major refactoring was also performed in crates/flagd/src/resolver/rest.rs, where the custom HTTP client and OFREP implementation were replaced by delegating to the new open-feature-ofrep crate. This change streamlines the flagd provider's REST resolver, making it more maintainable and leveraging a dedicated external OFREP implementation. The open-feature-ofrep crate was updated to use workspace dependencies and now includes a cert_path option for TLS configurations. The changes are well-executed and enhance the overall architecture.
This PR is not done, we need to merge #117 first. It represents how workspace split would look like