Repository navigation
test: add regression test for Postgres SearchIndexServerStatsDAO incrementStats SQL - #36785
Closed
sentry[bot] wants to merge 1 commit into
Closed
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Contributor
|
Closing: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
COLLATE-BACKEND-DE captured
PSQLException: ERROR: column "search_index_server_statsireaderwarnings" does not existduring distributed search index runs whenStageStatsTracker.flushupdates Postgres stats on conflict.While the typo
search_index_server_statsIreaderWarningsis already fixed onmaster(usingsearch_index_server_stats.readerWarnings), recent release-2.0 builds continued to encounter the failure.This PR adds
SearchIndexServerStatsDAOSqlTest, a standalone unit test that inspects the Postgres@ConnectionAwareSqlUpdateannotation onSearchIndexServerStatsDAO.incrementStatsand validates that:search_index_server_stats.<col>.This test can be backported to release branches (like 2.0) to catch and prevent regressions.
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
incrementStatsDO UPDATE SQL for search index server stats uses correctly qualified column references.Unit tests
SearchIndexServerStatsDAOSqlTestBackend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording:
Not applicable — backend-only test change with no UI impact.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.REVIEW.md(thepr-checklistskill runs it) and fixed every 🔴 finding, or answered it on the line below.docs/decisions/(see itsREADME.md). This description is gone fromgit logafter the squash-merge.Fixes COLLATE-BACKEND-DE
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.