Skip to content

fix(playwright): reach denied glossary and term by URL in deny-permission tests - #37111

Merged
anuj-kumary merged 3 commits into
mainfrom
anuj-kumary/glossary.spec-failed-check
Nov 5, 2026
Merged

anuj-kumary merged 3 commits into
mainfrom
anuj-kumary/glossary.spec-failed-check

Conversation

@anuj-kumary

Copy link
Copy Markdown
Member

Describe your changes

Glossary.spec.ts › Verify Glossary Deny Permission and Verify Glossary Term Deny Permission time out on every retry, on both MySQL and PostgreSQL, in nightly AUT run 41934979088. They passed in the previous main nightly (image om-27a4fb14).

Cause: #36952 made list endpoints leave out rows that a deny rule refuses (ADR:2026-11-03-a-listing-returns-only-rows-the-caller-may-read). Both tests tag the entity with a deny All tag rule and then went through the list:

  • Glossary test: waited for the glossary in the left panel. The page snapshot shows it missing from the 63 listed glossaries.
  • Term test: clicked the term in the glossary's terms table. The table now shows the empty state.

The product works as intended; the tests were out of date.

Fix (tests only):

  • Open the denied glossary or term by its URL. The 403 sends the user to /403, which shows permission-error-placeholder.
  • In the term test, also check through the API that the data consumer's GET /glossaryTerms?glossary=<id> leaves the denied term out. That pins the new listing behaviour without a not.toBeVisible check, which would pass even if nothing loaded.

Type of change

  • Bug fix (test)

Test evidence

🤖 Generated with Claude Code

…sion tests

#36952 made listings leave out rows a deny rule refuses
(ADR:2026-11-03-a-listing-returns-only-rows-the-caller-may-read), so the
denied glossary no longer appears in the left panel and the denied term no
longer appears in the terms table. Both tests waited on a row that is never
rendered and hit the 60s timeout on every retry in the nightly.

Open the entity by URL and assert the permission placeholder, and assert the
term is left out of the data consumer's glossaryTerms listing.
@anuj-kumary
anuj-kumary requested a review from a team as a code owner November 5, 2026 07:38
@anuj-kumary
anuj-kumary requested a review from sweta1308 November 5, 2026 07:38
@github-actions github-actions Bot added the UI UI specific issues label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@anuj-kumary anuj-kumary added safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Nov 5, 2026
@anuj-kumary
anuj-kumary enabled auto-merge (squash) November 5, 2026 08:09
@gitar-bot

gitar-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · Changes only Playwright permission tests to access denied glossary records directly and assert listing omission; executable product behavior remains unchanged.

Updates the Glossary deny-permission and term deny-permission Playwright tests to open the denied glossary or term by URL, expecting the /403 placeholder, and adds an API check that GET /glossaryTerms?glossary=<id> omits the denied term. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@anuj-kumary
anuj-kumary merged commit ad8ce11 into main Nov 5, 2026
62 checks passed
@anuj-kumary
anuj-kumary deleted the anuj-kumary/glossary.spec-failed-check branch November 5, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants