Repository navigation
fix(playwright): reach denied glossary and term by URL in deny-permission tests - #37111
Conversation
…sion tests #36952 made listings leave out rows a deny rule refuses (ADR:2026-11-03-a-listing-returns-only-rows-the-caller-may-read), so the denied glossary no longer appears in the left panel and the denied term no longer appears in the terms table. Both tests waited on a row that is never rendered and hit the 60s timeout on every retry in the nightly. Open the entity by URL and assert the permission placeholder, and assert the term is left out of the data consumer's glossaryTerms listing.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ Approved🟢 Low risk · Changes only Playwright permission tests to access denied glossary records directly and assert listing omission; executable product behavior remains unchanged. Updates the Glossary deny-permission and term deny-permission Playwright tests to open the denied glossary or term by URL, expecting the VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes
Glossary.spec.ts› Verify Glossary Deny Permission and Verify Glossary Term Deny Permission time out on every retry, on both MySQL and PostgreSQL, in nightly AUT run 41934979088. They passed in the previous main nightly (imageom-27a4fb14).Cause: #36952 made list endpoints leave out rows that a deny rule refuses (
ADR:2026-11-03-a-listing-returns-only-rows-the-caller-may-read). Both tests tag the entity with adeny Alltag rule and then went through the list:The product works as intended; the tests were out of date.
Fix (tests only):
/403, which showspermission-error-placeholder.GET /glossaryTerms?glossary=<id>leaves the denied term out. That pins the new listing behaviour without anot.toBeVisiblecheck, which would pass even if nothing loaded.Type of change
Test evidence
🤖 Generated with Claude Code