Skip to content

test(playwright): align specs with the 15/25/50 list page sizes from #35288 - #37234

Merged
sweta1308 merged 1 commit into
mainfrom
fix-pagination-playwright-page-size
Nov 6, 2026
Merged

sweta1308 merged 1 commit into
mainfrom
fix-pagination-playwright-page-size

Conversation

@sweta1308

@sweta1308 sweta1308 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes:

Follow-up to #35288 (issue #35468). Fixes Playwright failures on main from the nightly run at e21b5ff: https://github.com/open-metadata/OpenMetadata/actions/runs/42151309967

#35288 changed list defaults to 15: column tables and data-model columns dropped from 50, Audit Logs from 25, and Memories went up from 10. It also made usePaging ignore a URL pageSize that isn't one of the page's options. Several specs still assumed the old sizes. The last main run before #35288 (41956205227) had none of these failures.

Spec Failure Fix
Pages/AuditLogs.spec.ts expected 25, got 15 / Page expect the 15 default
Features/Table.spec.ts › nested columns expand/collapse dim_customer.shipping_address is column 28, now on page 2 use dim_location (nested address is #4)
Features/Table.spec.ts › nested fields table test_col_0044 is on page 3 use test_col_0004
Features/Dashboards.spec.ts › data model revenue_metrics_0031 is column 50 use revenue_metrics_0001
Features/Table.spec.ts › column panel on page 2 waited for offset=50 wait for offset=15
Features/ContextCenterMemories.spec.ts waited for limit=10 wait for limit=15; seed 16 memories so the pagination tests get their own second page
Pages/TestSuite.spec.ts › search from a later page ?pageSize=1 now ignored, so there's no page 2 and Next times out seed 15 more suites, use pageSize=15, clean up all of them
Features/IngestionListNameSorting.spec.ts › sorted page across reload same ?pageSize=1 problem seed 15 filler agents; page 2 must not be empty
Features/AIMode/ConnectionServiceDetails.spec.ts › pages through databases ?pageSize=2 ignored, so database 3 shows on page 1 seed 16 zero-padded databases, page at 15

Also: Table.spec.ts › "should persist page size" picked 15 / Page, which is now the default, so it passed without testing anything. It now picks 25.

The Metrics Pagination.spec failure is already fixed on main by #37212. The other failures in that run (workflow/login boot, Glossary heading, visual baselines, RDF) aren't caused by page size and aren't touched here.

Type of change:

  • Bug fix

High-level design:

N/A, test-only changes.

Tests:

Use cases covered

  • Every spec above runs at the 15/25/50 list sizes, and the paging specs seed their own second page instead of relying on an off-scale pageSize.

Playwright

  • ESLint and Prettier pass on all changed specs.
  • Ran all 12 changed tests locally against a 2.0 server with sample data loaded (--retries=0): 12 passed. The 3 sample-data column tests failed once with a transient "Unable to preload CSS" app error under 3 workers, then passed run serially.

🤖 Generated with Claude Code

…35288

#35288 moved list defaults to 15 (column tables and data model columns
from 50, Audit Logs from 25, Memories from 10) and made usePaging drop a
URL pageSize outside the page's options. Specs still assumed the old
sizes and broke on main.

- AuditLogs: default page size is 15.
- Table/Dashboards columns: use nested/tag rows that sit on page 1, and
  wait for offset=15 on page 2.
- Table "should persist page size": pick 25, not the default 15.
- ContextCenterMemories: wait for limit=15; seed 16 memories so the
  pagination tests own their second page.
- TestSuite, IngestionListNameSorting, AI-mode ConnectionServiceDetails:
  stop forcing a second page with an off-scale ?pageSize=1/2, which the
  list now ignores; seed one more row than a 15-row page instead.
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Nov 6, 2026
@gitar-bot

gitar-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · Only Playwright specs, fixtures, and expected page sizes change; application runtime behavior and public interfaces remain untouched.

Realigns Playwright specs with the 15/25/50 list page sizes introduced in #35288, updating expected defaults, column and memory seeding, and pagination URLs so they no longer rely on off-scale page sizes. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@sweta1308
sweta1308 merged commit 1de8a8e into main Nov 6, 2026
60 of 62 checks passed
@sweta1308
sweta1308 deleted the fix-pagination-playwright-page-size branch November 6, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants