Repository navigation
test(playwright): align specs with the 15/25/50 list page sizes from #35288 - #37234
Conversation
…35288 #35288 moved list defaults to 15 (column tables and data model columns from 50, Audit Logs from 25, Memories from 10) and made usePaging drop a URL pageSize outside the page's options. Specs still assumed the old sizes and broke on main. - AuditLogs: default page size is 15. - Table/Dashboards columns: use nested/tag rows that sit on page 1, and wait for offset=15 on page 2. - Table "should persist page size": pick 25, not the default 15. - ContextCenterMemories: wait for limit=15; seed 16 memories so the pagination tests own their second page. - TestSuite, IngestionListNameSorting, AI-mode ConnectionServiceDetails: stop forcing a second page with an off-scale ?pageSize=1/2, which the list now ignores; seed one more row than a 15-row page instead.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ Approved🟢 Low risk · Only Playwright specs, fixtures, and expected page sizes change; application runtime behavior and public interfaces remain untouched. Realigns Playwright specs with the 15/25/50 list page sizes introduced in #35288, updating expected defaults, column and memory seeding, and pagination URLs so they no longer rely on off-scale page sizes. No issues found. VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Follow-up to #35288 (issue #35468). Fixes Playwright failures on main from the nightly run at e21b5ff: https://github.com/open-metadata/OpenMetadata/actions/runs/42151309967
#35288 changed list defaults to 15: column tables and data-model columns dropped from 50, Audit Logs from 25, and Memories went up from 10. It also made
usePagingignore a URLpageSizethat isn't one of the page's options. Several specs still assumed the old sizes. The last main run before #35288 (41956205227) had none of these failures.Pages/AuditLogs.spec.ts25, got15 / PageFeatures/Table.spec.ts› nested columns expand/collapsedim_customer.shipping_addressis column 28, now on page 2dim_location(nestedaddressis #4)Features/Table.spec.ts› nested fields tabletest_col_0044is on page 3test_col_0004Features/Dashboards.spec.ts› data modelrevenue_metrics_0031is column 50revenue_metrics_0001Features/Table.spec.ts› column panel on page 2offset=50offset=15Features/ContextCenterMemories.spec.tslimit=10limit=15; seed 16 memories so the pagination tests get their own second pagePages/TestSuite.spec.ts› search from a later page?pageSize=1now ignored, so there's no page 2 and Next times outpageSize=15, clean up all of themFeatures/IngestionListNameSorting.spec.ts› sorted page across reload?pageSize=1problemFeatures/AIMode/ConnectionServiceDetails.spec.ts› pages through databases?pageSize=2ignored, so database 3 shows on page 1Also:
Table.spec.ts› "should persist page size" picked15 / Page, which is now the default, so it passed without testing anything. It now picks 25.The Metrics
Pagination.specfailure is already fixed on main by #37212. The other failures in that run (workflow/login boot, Glossary heading, visual baselines, RDF) aren't caused by page size and aren't touched here.Type of change:
High-level design:
N/A, test-only changes.
Tests:
Use cases covered
pageSize.Playwright
--retries=0): 12 passed. The 3 sample-data column tests failed once with a transient "Unable to preload CSS" app error under 3 workers, then passed run serially.🤖 Generated with Claude Code