Repository navigation
test(playwright): refresh stale visual-07 baselines and add missing visual read fixtures - #37237
Conversation
…al read fixtures Baselines in visual-07 were last captured before main picked up the core icon redraw, list pagination, glossary header and export scope card changes. The table and MCP settings scenarios also issued two new reads the visual fixture service did not answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ Approved🟢 Low risk · The changes only add mocked responses in the Playwright visual-test harness, affecting fixture-backed test rendering without changing application behavior. Refreshes stale visual-07 Playwright baselines and adds the missing visual read fixtures ( VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
This fixes the
visual-07shard of the scheduled Postgres Playwright run (https://github.com/open-metadata/OpenMetadata/actions/runs/42151309967/job/127676728051). It failed 28 of 314 tests onmain@e21b5ffb53f. This is a test-only fix, so there is no linked issue.RCA
The failures had two independent causes.
1. Read fixtures added after the visual suite (17 tests). The visual lane answers every
GET /api/v1/**from fixtures and fails a test on any read it doesn't answer (assertVisualReadFixtures). Two features merged after the visual suite (#36640) and added reads that the fixture service never learned:Missing visual read fixture: ontologyConcepts/boundTo/table/<id>TableLinkedConceptsnow asks which ontology concepts are bound to the table on every table page.Missing visual read fixture: system/mcp/toolsuseMcpConfigurationnow fetches the tool names.settings-app-McpApplication(2)Fix:
visualData.tsnow answers both reads.boundToreturns{ links: [] }. No concept is bound to the fixture assets, so the trace stays hidden, which matches what the page rendered before.mcp/toolsreturns a fixed list of tool names. Every tool stays enabled, so the names only fill the closed picker's options.2. Baselines captured before later UI changes reached the branch (11 tests). #36640 last re-captured its Linux baselines on Nov 4 15:31Z. It then merged
main(Nov 5 08:55Z) and landed without capturing them again. UI changes that reachedmainin between, or merged right after, changed what these screens render:connection-branch-*(copy button)Copy01iconcopy01.svg)announcement-card-Critical,announcement-all-dialogAlertCircleiconalert-circle.svg)rolesglossaryexplore-export-visible,explore-export-allEach difference was checked side by side against the CI
-actual.png. All of them are intended UI changes, not regressions. To check that the new images are deterministic, the first attempt was compared with the retry. They differ by at most 169 px of anti-aliasing, well inside the 1% tolerance.Fix: each of these 11 baselines is replaced with that run's own
-actual.png. Those images come from the same Linux CI renderer and regular UI bundle the lane uses, so they aren't a local macOS capture.Not covered here
visual-01…visual-06) and several chromium shards also failed in this run. This PR only coversvisual-07.Type of change:
High-level design:
N/A — test fixtures and baseline images only.
Tests:
Use cases covered
Playwright
make ui-checkstyle-changed,yarn lint:playwright(0 errors),yarn test:eslint-rules,node scripts/generate-playwright-rule-table.mjs --check: all pass.Checklist:
🤖 Generated with Claude Code