Skip to content

test(playwright): refresh stale visual-07 baselines and add missing visual read fixtures - #37237

Merged
shah-harshit merged 2 commits into
mainfrom
shah-harshit/trj62
Nov 6, 2026
Merged

shah-harshit merged 2 commits into
mainfrom
shah-harshit/trj62

Conversation

@shah-harshit

Copy link
Copy Markdown
Contributor

Describe your changes:

This fixes the visual-07 shard of the scheduled Postgres Playwright run (https://github.com/open-metadata/OpenMetadata/actions/runs/42151309967/job/127676728051). It failed 28 of 314 tests on main@e21b5ffb53f. This is a test-only fix, so there is no linked issue.

RCA

The failures had two independent causes.

1. Read fixtures added after the visual suite (17 tests). The visual lane answers every GET /api/v1/** from fixtures and fails a test on any read it doesn't answer (assertVisualReadFixtures). Two features merged after the visual suite (#36640) and added reads that the fixture service never learned:

Error Introduced by Tests
Missing visual read fixture: ontologyConcepts/boundTo/table/<id> #36868 (Ontology Studio v7). TableLinkedConcepts now asks which ontology concepts are bound to the table on every table page. Overlays dark (10), State variants dark (5)
Missing visual read fixture: system/mcp/tools #37165 (disable individual MCP tools). useMcpConfiguration now fetches the tool names. Settings extensions light/dark settings-app-McpApplication (2)

Fix: visualData.ts now answers both reads.

  • boundTo returns { links: [] }. No concept is bound to the fixture assets, so the trace stays hidden, which matches what the page rendered before.
  • mcp/tools returns a fixed list of tool names. Every tool stays enabled, so the names only fill the closed picker's options.

2. Baselines captured before later UI changes reached the branch (11 tests). #36640 last re-captured its Linux baselines on Nov 4 15:31Z. It then merged main (Nov 5 08:55Z) and landed without capturing them again. UI changes that reached main in between, or merged right after, changed what these screens render:

Baseline Change Source
5 × connection-branch-* (copy button) redrawn Copy01 icon #36954 (copy01.svg)
announcement-card-Critical, announcement-all-dialog redrawn AlertCircle icon #36954 (alert-circle.svg)
roles pagination footer now shown whenever a list has items #35468 / 895c970
glossary glossary header restyled to match the Metrics title #37123, #37179
explore-export-visible, explore-export-all selected export-scope card now has a brand border core styling change, intended

Each difference was checked side by side against the CI -actual.png. All of them are intended UI changes, not regressions. To check that the new images are deterministic, the first attempt was compared with the retry. They differ by at most 169 px of anti-aliasing, well inside the 1% tolerance.

Fix: each of these 11 baselines is replaced with that run's own -actual.png. Those images come from the same Linux CI renderer and regular UI bundle the lane uses, so they aren't a local macOS capture.

Not covered here

  • Other visual shards (visual-01…visual-06) and several chromium shards also failed in this run. This PR only covers visual-07.
  • The 17 tests that failed on a missing fixture never reached their screenshot. Their baselines may also be stale; this PR's visual lane run will show that.

Type of change:

  • Bug fix

High-level design:

N/A — test fixtures and baseline images only.

Tests:

Use cases covered

  • The visual-07 scenarios listed above render against the fixtures and match their baselines.

Playwright

  • This PR's visual lane is the verification. Baselines are Linux-renderer captures and cannot be checked on macOS.
  • Local: make ui-checkstyle-changed, yarn lint:playwright (0 errors), yarn test:eslint-rules, node scripts/generate-playwright-rule-table.mjs --check: all pass.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is descriptive.

🤖 Generated with Claude Code

…al read fixtures

Baselines in visual-07 were last captured before main picked up the core
icon redraw, list pagination, glossary header and export scope card changes.
The table and MCP settings scenarios also issued two new reads the visual
fixture service did not answer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shah-harshit
shah-harshit requested a review from a team as a code owner November 6, 2026 06:21
@shah-harshit shah-harshit added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 6, 2026
@shah-harshit shah-harshit self-assigned this Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@shah-harshit
shah-harshit enabled auto-merge (squash) November 6, 2026 06:53
@gitar-bot

gitar-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · The changes only add mocked responses in the Playwright visual-test harness, affecting fixture-backed test rendering without changing application behavior.

Refreshes stale visual-07 Playwright baselines and adds the missing visual read fixtures (ontologyConcepts/boundTo and system/mcp/tools) in visualData.ts so the 28 failing tests in that shard render against fixtures again. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@shah-harshit
shah-harshit merged commit 0042a9f into main Nov 6, 2026
61 of 62 checks passed
@shah-harshit
shah-harshit deleted the shah-harshit/trj62 branch November 6, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants