Repository navigation
[2.0] Fixes 37207: search_metadata returns requested lineage as edge ends - #37247
Open
gh-bot-collate[bot] wants to merge 1 commit into
Open
gh-bot-collate[bot] wants to merge 1 commit into
gh-bot-collate[bot] wants to merge 1 commit into
Conversation
15 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #37208 to
2.0.db9448214a23efe71e5bb6f4e00906b760dbd65bResolution notes
Backport notes: PR #37208 → 2.0
Cherry-pick of
db9448214a23efe71e5bb6f4e00906b760dbd65b("Fixes 37207:search_metadata returns requested lineage as edge ends") onto
2.0.Conflict
Only
openmetadata-mcp/src/main/resources/json/data/mcp/tools.jsonconflicted,in the
search_metadatatool'sfieldsparameter description. The other threefiles touched by the PR (
SearchMetadataTool.java,SearchMetadataCleanTest.java, and the new ADR doc) applied cleanly via thecherry-pick with no manual changes.
The conflict was a pure textual collision, not a logic conflict: on
main,this same description string was already carrying an unrelated addition (doc
text for
parent,childrenCountandmetricGroupfields, from a feature notpresent on
2.0). That text does not exist on2.0, so the two sides'pre-images differed and git couldn't auto-merge the hunk.
Resolution
Took
2.0's existing description text as the base (without theparent/childrenCount/metricGroupwording, since that feature isn't on thisbranch) and applied only this PR's actual edit on top of it:
upstreamLineageto the list of capped "bulk fields".upstreamLineageedges are returnedtrimmed to
fromEntity/pipelineFQN+type, and thatget_entity_lineage(with
upstreamDepth/downstreamDepth/includeColumnLineage/includeSql/nextCursor) is how a caller gets full edge detail.Verified
get_entity_lineageand all the parameters/fields referenced in thenew text (
upstreamDepth,downstreamDepth,includeColumnLineage,includeSql,nextCursor) already exist intools.jsonon2.0, so the newdoc text doesn't point at anything absent from this branch.
No conflict markers remain; the JSON structure (bracket/comma placement) is
intact — I read the surrounding lines after editing to confirm.
For the reviewer
that it lacks the
parent/childrenCount/metricGroupwording (correctlyout of scope here) and lacks
parent, metricGroupin the "References" listfor the same reason. Everything else matches main's intent for this PR.
docs/decisions/2026-11-06-search-metadata-returns-requested-lineage-as-edge-ends.md)references a sibling ADR,
ADR:2026-10-29-search-metadata-hits-show-their-place-in-a-hierarchy,that does not exist under
docs/decisions/on2.0. This is a documentationcross-reference only (no code/behavior depends on it), so it was left as-is
rather than edited — flagging it here in case the reviewer wants to drop or
annotate that line.
openmetadata-mcp/src/main/resources/json/data/mcp/tools.jsonis leftunstaged (still shows as
UUfrom the in-progress cherry-pick) per workflowinstructions — the next step stages it.
Opened from openmetadata-collate, which holds the credentials needed to open a PR here. It merges itself once this branch's required checks pass — no review needed. If a check fails it stays open and the author of #37208 is asked to look.
resolver run