Skip to content

Fixes #37263: store scheduleInterval when a pipeline PUT or PATCH changes only the cadence - #37264

Merged
TeddyCr merged 1 commit into
open-metadata:mainfrom
yashwantakashlal:fix-37263-schedule-interval-update
Nov 6, 2026
Merged

TeddyCr merged 1 commit into
open-metadata:mainfrom
yashwantakashlal:fix-37263-schedule-interval-update

Conversation

@yashwantakashlal

Copy link
Copy Markdown
Contributor

Fixes #37263

Describe your changes

PipelineRepository.PipelineUpdater.entitySpecificUpdate now records scheduleInterval like the other pipeline fields, so a PUT (createOrUpdate) or PATCH that changes only the cadence is stored with a change-description entry. Before, such an update was acknowledged in the response but not persisted; it only landed when another tracked field (tasks, concurrency, ...) changed in the same request.

PipelineResourceIT.test_pipelineScheduleIntervalUpdate_200_OK creates a pipeline with a cadence, patches only the cadence, and asserts that a fresh GET returns the new value with a bumped version.

Type of change

  • Bug fix

Checklist

  • I have read the CONTRIBUTING document.
  • My PR title starts with Fixes #<issue>.
  • I have added tests for the change.
  • UI change: N/A

@yashwantakashlal
yashwantakashlal requested a review from a team as a code owner November 6, 2026 12:44
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot

gitar-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Persisting cadence-only scheduleInterval updates changes pipeline execution timing, which could trigger runs at an unintended frequency.

Persists scheduleInterval in PipelineRepository.PipelineUpdater.entitySpecificUpdate so a PUT or PATCH that changes only the cadence is stored with a change-description entry instead of being dropped. Covered by PipelineResourceIT.test_pipelineScheduleIntervalUpdate_200_OK. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@TeddyCr TeddyCr added the safe to test Add this label to run secure Github workflows on PRs label Nov 6, 2026
@TeddyCr
TeddyCr enabled auto-merge (squash) November 6, 2026 17:13
@TeddyCr
TeddyCr merged commit e906dd7 into open-metadata:main Nov 6, 2026
87 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scheduleInterval is not stored when a pipeline PUT or PATCH changes only the cadence

4 participants