Repository navigation
Fixes #37263: store scheduleInterval when a pipeline PUT or PATCH changes only the cadence - #37264
Conversation
… or PATCH changes only the cadence
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ Approved🟡 Medium risk · Persisting cadence-only scheduleInterval updates changes pipeline execution timing, which could trigger runs at an unintended frequency. Persists VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Fixes #37263
Describe your changes
PipelineRepository.PipelineUpdater.entitySpecificUpdatenow recordsscheduleIntervallike the other pipeline fields, so aPUT(createOrUpdate) orPATCHthat changes only the cadence is stored with a change-description entry. Before, such an update was acknowledged in the response but not persisted; it only landed when another tracked field (tasks,concurrency, ...) changed in the same request.PipelineResourceIT.test_pipelineScheduleIntervalUpdate_200_OKcreates a pipeline with a cadence, patches only the cadence, and asserts that a freshGETreturns the new value with a bumped version.Type of change
Checklist
Fixes #<issue>.