Repository navigation
test(migrations): cover the entity_extension collation step on 2.0 - #37280
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ Approved🟢 Low risk · The change only updates migration test mocks and assertions; it does not alter migration execution or stored-data behavior. Test-only change to VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Part of #37180
Why
PR #37186 added the
entity_extensioncollation step to the 2.0.8 Java migration, butWorkflowRedeployEntryPointTeststill runs that migration with a mocked database handle and did not mock the new step. So on2.0the MySQL case fails with aNullPointerException. PR #37186's unit test job was cancelled, so its CI did not show this.What changes
Test only. The test now mocks
EntityExtensionCollationAlignment, and checks that the step runs on MySQL and not on Postgres. This is the same change PR #37184 made onmain.Tests
WorkflowRedeployEntryPointTest(2) andEntityExtensionCollationAlignmentTest(6) pass locally. Before this change, the MySQL case ofWorkflowRedeployEntryPointTestfailed onorigin/2.0.