Skip to content

test(migrations): cover the entity_extension collation step on 2.0 - #37280

Merged
manerow merged 1 commit into
2.0from
fix/2.0-collation-entry-point-test
Nov 6, 2026
Merged

manerow merged 1 commit into
2.0from
fix/2.0-collation-entry-point-test

Conversation

@manerow

@manerow manerow commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Part of #37180

Why

PR #37186 added the entity_extension collation step to the 2.0.8 Java migration, but WorkflowRedeployEntryPointTest still runs that migration with a mocked database handle and did not mock the new step. So on 2.0 the MySQL case fails with a NullPointerException. PR #37186's unit test job was cancelled, so its CI did not show this.

What changes

Test only. The test now mocks EntityExtensionCollationAlignment, and checks that the step runs on MySQL and not on Postgres. This is the same change PR #37184 made on main.

Tests

WorkflowRedeployEntryPointTest (2) and EntityExtensionCollationAlignmentTest (6) pass locally. Before this change, the MySQL case of WorkflowRedeployEntryPointTest failed on origin/2.0.

@manerow
manerow requested a review from a team as a code owner November 6, 2026 14:47
@manerow
manerow requested review from yan-3005 and removed request for a team November 6, 2026 14:47
@manerow manerow added the backend label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 6, 2026
@gitar-bot

gitar-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · The change only updates migration test mocks and assertions; it does not alter migration execution or stored-data behavior.

Test-only change to WorkflowRedeployEntryPointTest that mocks the new EntityExtensionCollationAlignment step added in the 2.0.8 migration, and asserts it runs on MySQL but not on Postgres. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

This branch was successfully deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant