Open
Conversation
LeoXing1996
reviewed
Oct 26, 2021
| # c) ``Pass``: Successfully pass the regression test. | ||
| # 3. We should check the representation of the result value in metafile and the | ||
| # generated log table. (Related to convert_str_metric_value() function) | ||
| # 4. The matric name should be mapped to the standard one. Please check |
Collaborator
There was a problem hiding this comment.
matric? Maybe Metric?
LeoXing1996
reviewed
Oct 26, 2021
|
|
||
| def main(): | ||
| args = parse_args() | ||
| get_log_files(args) |
Collaborator
There was a problem hiding this comment.
Maybe data_dict = get_log_files(args)?
zengyh1900
added
kind/enhancement
Collaborator
|
This feature has been supported in https://github.com/open-mmlab/mmgeneration/tree/dev-1.x/.dev_scripts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.