Skip to content

Conversation

@ChiragAgg5k
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies storage device initialization by removing the region parameter and consolidating the logic into a new StorageFactory class. The old Device class is completely removed, eliminating multi-region support and environment variable fallbacks.

  • Replaced Storage\Device class with new StorageFactory class
  • Removed region parameter from storage device methods
  • Simplified storage initialization to use DSN connection strings only
  • Updated all usages in Docker.php and app/http.php

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Executor/StorageFactory.php New factory class that creates storage devices from DSN connection strings, replacing the old Device class with simplified logic
src/Executor/Storage/Device.php Deleted old storage device class that supported multi-region configuration and environment variable fallbacks
src/Executor/Runner/Docker.php Updated to use StorageFactory instead of Storage\Device, passing connection string directly to getDevice() method
app/http.php Updated to instantiate StorageFactory instead of Storage\Device and pass it to the Docker runner

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChiragAgg5k ChiragAgg5k merged commit d095a9d into main Dec 10, 2025
3 checks passed
@ChiragAgg5k ChiragAgg5k deleted the remove-region branch December 10, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants