-
Notifications
You must be signed in to change notification settings - Fork 4
chore: remove region param from storage device #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcc1bba to
6bad47a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies storage device initialization by removing the region parameter and consolidating the logic into a new StorageFactory class. The old Device class is completely removed, eliminating multi-region support and environment variable fallbacks.
- Replaced
Storage\Deviceclass with newStorageFactoryclass - Removed region parameter from storage device methods
- Simplified storage initialization to use DSN connection strings only
- Updated all usages in
Docker.phpandapp/http.php
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Executor/StorageFactory.php | New factory class that creates storage devices from DSN connection strings, replacing the old Device class with simplified logic |
| src/Executor/Storage/Device.php | Deleted old storage device class that supported multi-region configuration and environment variable fallbacks |
| src/Executor/Runner/Docker.php | Updated to use StorageFactory instead of Storage\Device, passing connection string directly to getDevice() method |
| app/http.php | Updated to instantiate StorageFactory instead of Storage\Device and pass it to the Docker runner |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.