Improve profiles attribute table handling#7031
Merged
Merged
Conversation
Contributor
Author
|
Follows on from #7026 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7031 +/- ##
=========================================
Coverage 89.88% 89.88%
Complexity 6655 6655
=========================================
Files 748 748
Lines 20077 20077
Branches 1969 1969
=========================================
Hits 18047 18047
Misses 1435 1435
Partials 595 595 ☔ View full report in Codecov by Sentry. |
jack-berg
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use List<AttributeKeyValue<?>> rather than Attributes, as the latter's map semantics are not appropriate for all use cases of the Profile.attribute_table field in the wire message.