feat(instrumentation-mongoose): Support v7 and v8#2353
feat(instrumentation-mongoose): Support v7 and v8#2353trentm merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 90.97% 90.56% -0.42%
==========================================
Files 146 157 +11
Lines 7492 7631 +139
Branches 1502 1574 +72
==========================================
+ Hits 6816 6911 +95
- Misses 676 720 +44
|
a30b2d8 to
6075b12
Compare
6075b12 to
79ea242
Compare
|
@onurtemizkan I haven't reviewed this PR, yet. A side issue: I notice that you are force-pushing. If you are able, please don't force-push to a PR branch, at least not after there have been any reviews on it. It makes it harder to do subsequent re-reviews because it isn't clear what has changed from a previous commit. |
|
Thanks for looking into this @trentm, and yes I'll be careful not to force-push on reviewed code. FWIW these last couple were rebases on main. |
trentm
left a comment
There was a problem hiding this comment.
Thanks for the PR. This looks good, modulo a couple suggestions below.
Please also apply this change to the README.md:
diff --git a/plugins/node/instrumentation-mongoose/README.md b/plugins/node/instrumentation-mongoose/README.md
index c5500b14..31a19b4e 100644
--- a/plugins/node/instrumentation-mongoose/README.md
+++ b/plugins/node/instrumentation-mongoose/README.md
@@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-mongoose
## Supported Versions
-- [`mongoose`](https://www.npmjs.com/package/mongoose) versions `>=5.9.7 <7`
+- [`mongoose`](https://www.npmjs.com/package/mongoose) versions `>=5.9.7 <9`
## Usage
Co-authored-by: Trent Mick <trentm@gmail.com>
Co-authored-by: Trent Mick <trentm@gmail.com>
Note the warning about unhelpful npm behaviour in this workspace when the version of mongodb to test (by TAV) matches the version installed for the instrumentation-mongoose workspace. The version in instr-mongoose recently updated (in open-telemetry#2353), so it needs to update here as well.
…13587) This bumps all our internal OTEL instrumentation to their latest version. Mainly, this fixes two things: * Mongoose now supports v7 & v8 open-telemetry/opentelemetry-js-contrib#2353 * A variety of bug fixes, including a problem with http.get in ESM mode open-telemetry/opentelemetry-js#4857 - See: https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.53.0 Related: * open-telemetry/opentelemetry-js#4975 Issue about relaxing deps in "core" instrumentation packages * PR to bump deps in `@prisma/instrumentation`: prisma/prisma#25160 * PR to bump deps in `opentelemetry-instrument-remix`: justindsmith/opentelemetry-instrumentations-js#52 * PR to bump deps in `opentelemetry-instrumentation-fetch-node`: gas-buddy/opentelemetry-instrumentation-fetch-node#17 (which will also be superseded by #13485 eventually) * Closes #11499
Resolves: #1606
Which problem is this PR solving?
Related: getsentry/sentry-javascript#11499
Short description of the changes
Mongoose 7
removeMongoose DocsMongoose 8
countMongoose DocsfindOneAndRemoveMongoose DocsThe current set of tests is passing without any issues, except
findOneAndUpdate, which starts to create only one span, starting from version 7. I separated that test for v7/v8.To avoid separating the package because of type mismatches, I have added a few
// @ts-expect-errors inside tests with their reasons.