Skip to content

Only run Python3.6 contrib tests#2192

Merged
owais merged 3 commits into
open-telemetry:mainfrom
owais:dont-run-entire-contrib-workflow
Oct 14, 2021
Merged

Only run Python3.6 contrib tests#2192
owais merged 3 commits into
open-telemetry:mainfrom
owais:dont-run-entire-contrib-workflow

Conversation

@owais

@owais owais commented Oct 12, 2021

Copy link
Copy Markdown
Contributor

Description

We do not need to run the entire contrib test matrix on core. We need enough confidence that core API changes don’t break anything in contrib. It should be enough to run each test suite on just one version of Python to achieve that. So for core, we can run only Python3.6 contrib workflows. That should be more than enough IMO to ensure nothing breaks in core.

Also disabled contrib docker tests as contrib unit tests should be enough to catch any breakage.

Type of change

Please delete options that are not relevant.

  • Dev/Tooling enhancement
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing Tests

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested a review from a team October 12, 2021 20:23
@owais owais added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 12, 2021
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml Outdated
@owais owais force-pushed the dont-run-entire-contrib-workflow branch 2 times, most recently from 1d21090 to 93b667b Compare October 13, 2021 10:11
Comment thread .github/workflows/test.yml
@owais owais force-pushed the dont-run-entire-contrib-workflow branch from 93b667b to d6d46fe Compare October 13, 2021 15:13
@owais owais enabled auto-merge (squash) October 14, 2021 01:24
@owais owais merged commit 171569a into open-telemetry:main Oct 14, 2021
@owais owais deleted the dont-run-entire-contrib-workflow branch October 14, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants