Only run Python3.6 contrib tests#2192
Merged
owais merged 3 commits intoOct 14, 2021
Merged
Conversation
aabmass
reviewed
Oct 12, 2021
1d21090 to
93b667b
Compare
aabmass
approved these changes
Oct 13, 2021
93b667b to
d6d46fe
Compare
srikanthccv
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We do not need to run the entire contrib test matrix on core. We need enough confidence that core API changes don’t break anything in contrib. It should be enough to run each test suite on just one version of Python to achieve that. So for core, we can run only Python3.6 contrib workflows. That should be more than enough IMO to ensure nothing breaks in core.
Also disabled contrib docker tests as contrib unit tests should be enough to catch any breakage.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
Checklist: