Remove unused assertEqualSpanInstrumentationInfo#4310
Merged
xrmx merged 7 commits intoopen-telemetry:mainfrom Nov 26, 2024
Merged
Remove unused assertEqualSpanInstrumentationInfo#4310xrmx merged 7 commits intoopen-telemetry:mainfrom
xrmx merged 7 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
I am not sure if our stability guarantees extend to testing utils so I am fine with removing it outright. I am also not against adding a warning about the removal and remove it in a subsequent release. Feel free to bring it up in the SIG so we can get a concensus. |
Contributor
There were warnings at runtime already when using it because the helper was accessing a deprecated property so it shouldn't come as a surpise 😅 |
xrmx
approved these changes
Nov 26, 2024
xrmx
reviewed
Nov 26, 2024
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
lzchen
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It doesn't look like this repo uses assertEqualSpanInstrumentationInfo (grep).
All contrib repo uses were removed in open-telemetry/opentelemetry-python-contrib#3037.
This will break testing for any users that do
from opentelemetry.test.test_base import TestBaseand use assertEqualSpanInstrumentationInfo. However, there should have been warnings logged that lookup of instrumentation info has been deprecatedsince version 1.11.1via calls to that helper instead of assertEqualSpanInstrumentationScope (see contrib issue OP)Alternatively: We could add a
loggerto test_base or useprint/sys.stdoutto show a warning that assertEqualSpanInstrumentationInfo will be removed in a future release. Is that the approach we prefer?Fixes #4301
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Run all unit tests.
Does This PR Require a Contrib Repo Change?
Checklist: