Mark events API/SDK as deprecated#4654
Conversation
|
The changes here lgtm if we agree that this will be part of next release. Thanks for linking those spec issues. Could we also have a dedicated Python issue to include on the Python Logging RC board? |
|
Sure created #4655 and added it to the board |
aabmass
left a comment
There was a problem hiding this comment.
Can you also add deprecation to the module level public functions like
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
|
Ack I added the deprecation warnings to the module level public functions |
Should we go ahead and fix the contrib packages now? I don't remember if the independent versioned GenAI packages test against opentelemetry-api @ HEAD or not |
Individual GenAI packages are being tested against the main and also against the lowest supported version of the API. I don't think it will be a problem in terms of testing because we are just deprecating things. Typechecker won't like this change though |
|
I will go ahead and update the Contrib repo implementations now.. Up to y'all if you want to block this PR until that is done. IMO we should just merge it |
|
I'm tagging this with the |
* Mark events API/SDK as deprecated * Add PR # to changelog * Update CHANGELOG.md Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> * Add deprecatrred warnings to event methods * Update CHANGELOG.md * Update __init__.py * Update __init__.py * Add to deprecation that this will be removed in the future --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Aaron Abbott <aaronabbott@google.com>
* Mark events API/SDK as deprecated * Add PR # to changelog * Update CHANGELOG.md Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> * Add deprecatrred warnings to event methods * Update CHANGELOG.md * Update __init__.py * Update __init__.py * Add to deprecation that this will be removed in the future --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Description
Mark the Events API/SDK as deprecated. The Logs API/SDK should be used instead. An event is now a
LogRecordwith theevent_namefield set.See open-telemetry/opentelemetry-specification#4319 and open-telemetry/opentelemetry-specification#4260 (comment)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Just marking stuff as deprecated.
Does This PR Require a Contrib Repo Change?
Checklist: