Skip to content

feat: make retryable gRPC error codes configurable for gRPC exporters#4917

Merged
aabmass merged 11 commits intoopen-telemetry:mainfrom
herin049:feat/conf-grpc-retry-codes
May 8, 2026
Merged

feat: make retryable gRPC error codes configurable for gRPC exporters#4917
aabmass merged 11 commits intoopen-telemetry:mainfrom
herin049:feat/conf-grpc-retry-codes

Conversation

@herin049
Copy link
Copy Markdown
Contributor

@herin049 herin049 commented Feb 17, 2026 •
edited
Loading

Description

Adds support for configuring the retry-able gRPC error codes for gRPC exporters.

Fixes #4904

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Relevant unit tests have been added.

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@herin049 herin049 requested a review from a team as a code owner February 17, 2026 05:19
@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

tammy-baylis-swi commented Feb 17, 2026

Would it be feasible to also support this config by env var? Maybe something like OTEL_PYTHON_EXPORTER_OTLP_GRPC_RETRYABLE_ERROR_CODES, which is quite long but similar to other grpc exporter env vars.

@herin049
Copy link
Copy Markdown
Contributor Author

herin049 commented Feb 17, 2026

Would it be feasible to also support this config by env var? Maybe something like OTEL_PYTHON_EXPORTER_OTLP_GRPC_RETRYABLE_ERROR_CODES, which is quite long but similar to other grpc exporter env vars.

Definitely, I can add this!

@herin049 herin049 force-pushed the feat/conf-grpc-retry-codes branch 2 times, most recently from 60c3e69 to 12ea823 Compare February 18, 2026 20:48
tammy-baylis-swi
tammy-baylis-swi reviewed Feb 19, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py Outdated
tammy-baylis-swi
tammy-baylis-swi approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm as a nice, simple, experimental feature.

@tammy-baylis-swi tammy-baylis-swi moved this to Ready for review in Python PR digest Feb 19, 2026
MikeGoldsmith
MikeGoldsmith approved these changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

Comment thread exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_exporter_mixin.py
@kasium
Copy link
Copy Markdown
Contributor

kasium commented Mar 12, 2026

Can someone please have a look on the CI? The feature is really needed by me :-)

@herin049 herin049 force-pushed the feat/conf-grpc-retry-codes branch from 7439e6a to fa3f686 Compare March 13, 2026 01:42
@herin049 herin049 moved this from Ready for review to Approved PRs in Python PR digest Mar 13, 2026
@herin049
Copy link
Copy Markdown
Contributor Author

herin049 commented Mar 13, 2026

Can someone please have a look on the CI? The feature is really needed by me :-)

@kasium Just waiting for a maintainer to merge this in, should be merged shortly.

@herin049 herin049 force-pushed the feat/conf-grpc-retry-codes branch from fa3f686 to f0df87e Compare March 13, 2026 17:41
@herin049 herin049 force-pushed the feat/conf-grpc-retry-codes branch from f0df87e to 93ca5fb Compare April 25, 2026 03:36
@herin049 herin049 force-pushed the feat/conf-grpc-retry-codes branch from 93ca5fb to e0e1797 Compare April 29, 2026 21:19
@aabmass
Copy link
Copy Markdown
Member

aabmass commented May 7, 2026

I dropped a comment on #4904 (comment)

@aabmass aabmass moved this from Approved PRs to Approved PRs that need fixes in Python PR digest May 7, 2026
aabmass
aabmass approved these changes May 7, 2026
View reviewed changes
Comment thread ...xporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_log_exporter/__init__.py Outdated
@herin049 herin049 force-pushed the feat/conf-grpc-retry-codes branch from 5553987 to 1e29138 Compare May 7, 2026 21:43
@herin049 herin049 moved this from Approved PRs that need fixes to Approved PRs in Python PR digest May 7, 2026
@aabmass aabmass enabled auto-merge (squash) May 8, 2026 04:06
@aabmass aabmass merged commit 50218b9 into open-telemetry:main May 8, 2026
480 checks passed
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Python PR digest May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

No one assigned

Labels

exporters

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow customization of retry error codes in OTLP grpc exporter

5 participants

@herin049 @tammy-baylis-swi @kasium @aabmass @MikeGoldsmith