Repository navigation
Fix username - #238
Open
qr243vbi wants to merge 1 commit into
Open
Fix username#238qr243vbi wants to merge 1 commit into
qr243vbi wants to merge 1 commit into
Conversation
mcepl
requested changes
Oct 29, 2026
mcepl
left a comment
Contributor
There was a problem hiding this comment.
I would merge it now, but could you, please, add unit tests for the helper in py2pack/utils.py, mocking pwd.getpwuid() to cover:
- A populated GECOS field returns the existing name.
- An empty GECOS field returns
pw_name.
The template test now uses the same helper to calculate its expected username, so it doesn't independently verify that fallback.
Contributor
|
@qr243vbi Please, at least allow maintainer’s edits on this PR, I will add those tests myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #235