Normalize checkpoint success flags and identifier handling to fix resume behavior#57
Merged
hemanth-asirvatham merged 1 commit intomainfrom Feb 10, 2026
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Successfulcolumn was stored as strings (e.g. "True", "true", "1"), causing already-done rows to be reprocessed.Description
Successfulcolumn when loading a saved CSV by coercing boolean-like values and matching common success strings ("true","1","yes","completed", etc.) before building thedoneset; change located insrc/gabriel/utils/openai_utils.py.done, filteringtodo_pairs, and during write-time deduplication so comparisons are type-consistent; updates insrc/gabriel/utils/openai_utils.py.written_identifiersstores string identifiers and useastype(str)when checkingbatch_dfto avoid reappends of already-saved rows; updates insrc/gabriel/utils/openai_utils.py.test_resume_treats_string_success_values_as_completedtotests/test_reset_files.pythat seeds a checkpoint CSV with string-valuedSuccessfulentries and verifiesreset_files=Falseresumes without reprocessing those rows.Testing
pytest -q tests/test_reset_files.py tests/test_openai_dummy.pyand both tests suites passed locally (6 passedfor the two test files run).Codex Task