Improve Rank robustness for malformed text/id rows#60
Merged
hemanth-asirvatham merged 1 commit intomainfrom Feb 13, 2026
Merged
Improve Rank robustness for malformed text/id rows#60hemanth-asirvatham merged 1 commit intomainfrom
hemanth-asirvatham merged 1 commit intomainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.encode()on floats/NA), causing crashes during identifier derivation and downstream indexing.Description
_is_missing_scalarand_hash_text_identifierto safely detect missing scalars and produce stable sha1 identifiers only for valid text-like inputs._seed_ratings_from_rateto use safe hashing and drop invalid keys instead of raising.run) and recursive (_run_recursive) ranking entry paths to filter out malformed rows before processing, print a summary message when rows are dropped (count and percentage), andreset_indexafter filtering to avoid indexing issues.tests/test_basic.pyverifying malformed-row dropping behavior in standard and recursive modes.Testing
pytest -q tests/test_basic.py -k "rank_drops_malformed_rows or recursive_rank_drops_malformed_rows or rank_outputs_standard_errors"which passed.pytest -q tests/test_basic.py -k "rank and not screenshot"which passed (rank-related tests succeeded).Codex Task