Repository navigation
refactor: simplify scanner imports and SDK test setup - #2136
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for simplifying this. Owner-level merge-safety review: no blocking findings. Finding IDs, duplicate handling, provenance, and local/Cloud evidence remain consistent; cleanup changes are confined to tests. SDK/plugin builds, types, formatting, 286 scanner tests, 570 base/head comparisons, and cleanup checks passed locally with CI-pinned Bun 1.3.14. The full changed-suite run could not pass locally because of sandbox filesystem protections; exact-head CI is green across Linux, macOS, and Windows.
Summary
Remove 493 maintained lines across SDK scanner normalization and tests. The import pipeline already establishes each record's ID before projecting its evidence. The pipeline now attaches that ID directly to the projected evidence.
Changes
Testing
Risk and rollout
The finding ID, exclusion order, and local and Cloud evidence formats are preserved. The cleanup change is confined to the test harness. If the test body and its disposer both fail, the runtime preserves both errors in a
SuppressedError.Public disclosure review