Skip to content

fix(dedupe): correct rejected decisions in the open records review - #2139

Merged
kmbroai merged 1 commit into
mainfrom
dev/kyleb/dedupe-review-correction
Oct 29, 2026
Merged

kmbroai merged 1 commit into
mainfrom
dev/kyleb/dedupe-review-correction

Conversation

@kmbroai

@kmbroai kmbroai commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A hosted dedupe reviewer can use the wrong pair label even when the answer is valid JSON. A host can now ask the CLI to validate a pending tool call before it closes the review. The CLI returns the assigned labels and gives the reviewer one chance to fix the answer in the same session.

Changes

  • Check pending tool arguments against the existing screening and pair-review validators. Accept only the final validated answer.
  • Request a correction on the original review. Confirm cleanup before accepting a pending answer that was already valid.
  • Keep raw model output separate from the host’s pending flag. Only a request that advertised validation support accepts the flag.

Testing

  • Passed 108 focused records, validation, and severity tests, including a two-record batch that recovers from a wrong label. A second bad answer yields zero groups. An older host receives no extra request.
  • TypeScript and package formatting passed. All 58 GitHub checks that ran passed, including the Linux, macOS and Windows test shards. Six checks were skipped.
  • A separate local full-suite run encountered failures outside the three focused files. A policy test reproduced on unchanged main when the test directory appeared to be inside a Git worktree. It passed in an isolated directory.

Risk and rollout

The protocol is opt-in. Existing hosts can keep returning final results. A host that opts in must keep the original session open until it receives and handles the CLI’s feedback. This change does not retry an uncertain operation or replay a batch.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 29, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-29T20:06:36.954843Z 5b3cd0f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kmbroai
kmbroai merged commit aa56acb into main Oct 29, 2026
81 checks passed
@kmbroai
kmbroai deleted the dev/kyleb/dedupe-review-correction branch October 29, 2026 21:06
@github-actions github-actions Bot mentioned this pull request Oct 29, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants