Repository navigation
fix(auth): preserve IPv6 verification URL brackets - #232
Conversation
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
74e6b9e to
e18f3d9
Compare
a1162f8 to
df34f32
Compare
Keep IPv6 URL regression coverage alongside upstream device-code tests and preserve the large-output test behavior.
…/codex/external-pr-232
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mldangelo-oai
left a comment
There was a problem hiding this comment.
Thanks for catching this, @dipeshbabu, and for sticking with the fix! I especially appreciate the test that wraps an IPv6 link in another pair of brackets. It makes it easy to see which bracket the login URL needs to keep.
Summary
Preserve the closing host bracket in IPv6 login URLs while trimming surrounding punctuation.
Changes
Keep the structural IPv6 bracket and reuse the current subprocess test helpers. Cover enclosed URLs, paths, queries, ports, HTTPS requirements, and local-address exclusions.
Testing
9cfdc336, all 26 authentication tests passed with 74 assertions. Types and formatting passed.Risk and rollout
This fixes login-output parsing within the existing URL acceptance rules.
Public disclosure review
An existing automated comment contains a private review-report link. This update adds no private links.