Skip to content

fix(auth): preserve IPv6 verification URL brackets - #232

Merged
mldangelo-oai merged 10 commits into
openai:mainfrom
dipeshbabu:agent/preserve-ipv6-auth-url-bracket
Oct 30, 2026
Merged

mldangelo-oai merged 10 commits into
openai:mainfrom
dipeshbabu:agent/preserve-ipv6-auth-url-bracket

Conversation

@dipeshbabu

@dipeshbabu dipeshbabu commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Preserve the closing host bracket in IPv6 login URLs while trimming surrounding punctuation.

Changes

Keep the structural IPv6 bracket and reuse the current subprocess test helpers. Cover enclosed URLs, paths, queries, ports, HTTPS requirements, and local-address exclusions.

Testing

  • After merging main at 9cfdc336, all 26 authentication tests passed with 74 assertions. Types and formatting passed.
  • Installed the exact locked dependencies, verified native build-input equivalence, and rebuilt this branch's plugin bundle.
  • Three fresh reviews and independent verification passed. Full SDK validation and current-head CI remain pending. The previous CI run retained an unrelated Windows runtime-test cleanup failure after the artifact-download retry passed.

Risk and rollout

This fixes login-output parsing within the existing URL acceptance rules.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

An existing automated comment contains a private review-report link. This update adds no private links.

@github-actions github-actions Bot added the bug Something isn't working label Aug 3, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator

@codex review exact head 74e6b9e

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 74e6b9e523

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 74e6b9e523

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@dipeshbabu
dipeshbabu force-pushed the agent/preserve-ipv6-auth-url-bracket branch from 74e6b9e to e18f3d9 Compare August 4, 2026 05:58
@dipeshbabu
dipeshbabu force-pushed the agent/preserve-ipv6-auth-url-bracket branch from a1162f8 to df34f32 Compare August 20, 2026 17:56
dipeshbabu and others added 2 commits September 26, 2026 22:42
Keep IPv6 URL regression coverage alongside upstream device-code tests and preserve the large-output test behavior.
@mldangelo-oai mldangelo-oai added the area:auth Login, credentials, account access, and authentication recovery. label Oct 8, 2026
@mldangelo-oai mldangelo-oai removed the area:auth Login, credentials, account access, and authentication recovery. label Oct 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-30T14:48:25.399408Z
We couldn’t complete this review. Comment @codex review to try again.
04ef677 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @dipeshbabu, and for sticking with the fix! I especially appreciate the test that wraps an IPv6 link in another pair of brackets. It makes it easy to see which bracket the login URL needs to keep.

@mldangelo-oai
mldangelo-oai merged commit ad6ec65 into openai:main Oct 30, 2026
55 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 30, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants