Repository navigation
fix(windows): inspect finding receipts through extended paths - #2386
sylvesterkaczmarek wants to merge 13 commits into
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Both native long-path cases passed on Windows. The source check failed because the POSIX-only filename case was selected and skipped. The updated test selection keeps that case on Unix and keeps the native receipt checks on Windows. @codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
CI note for current head |
|
Independent validation of PR #2386 at Results:
The native cases exercise ordinary and extended-length filename inputs for a database whose filename crosses 260 characters. They read the expected receipt and check that the database contents and directory entries remain unchanged. Commands, run from the repository root with a fresh temporary directory for each invocation: python -m pytest plugins/codex-security/tests/test_finding_issue_receipts.py -m native_windows -q
python -m pytest plugins/codex-security/tests/test_finding_issue_receipts.py -qThis provides an independent check of the current head alongside the earlier Windows results in this discussion. It does not establish that an ordinary long filename fails under legacy Windows policy, and no live UNC share was tested. No machine-wide long-path setting or repository source was changed. |
|
Thanks @AmarGhugare for the independent native Windows checks and for clearly stating their limits. Great to have the two receipt cases and the whole module verified on Windows. @mldangelo-oai, thanks as well for the test and workflow follow-through. The current |
Summary
Fixes #2378. When the state directory fits within the legacy Windows path limit but its database filename crosses it, inspection can miss an existing finding receipt store.
Changes
Use the existing Windows extended-path conversion for the history existence check and the read-only SQLite URI. When the prefix alone would exceed the default Win32 SQLite filename budget, keep the ordinary filename in the URI. The test suite exercises drive and UNC spelling and reads a real long-path database through the workbench command on Windows. Existing tests cover missing stores, permission errors and inspection without migration.
The native Windows suite also exercises a 1,030-byte drive filename. It first opens the ordinary filename read-only as a control, then checks the workbench receipt, database bytes and directory entries. The Ubuntu inventory fixture includes the env utility name correction from #2678.
Testing
Risk and rollout
Writable SQLite connections and migrations retain their existing behavior. The Linux run covers UNC spelling through a test double. Live UNC access and an enforced legacy Windows policy remain unverified.
Public disclosure review
The existing checklist records review of the preceding revision. For this update, the branch, title, PR text, public discussion, links, commit metadata and cumulative diff were reviewed.