Skip to content

core: expose permission profile picker metadata#22928

Merged
viyatb-oai merged 1 commit into
mainfrom
codex/viyatb/profile-permissions-config
May 19, 2026
Merged

core: expose permission profile picker metadata#22928
viyatb-oai merged 1 commit into
mainfrom
codex/viyatb/profile-permissions-config

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

@viyatb-oai viyatb-oai commented May 15, 2026

Why

The /permissions picker needs a config-level way to distinguish legacy anonymous presets from named permission-profile mode. That signal cannot be inferred reliably in the TUI, especially for the edge case where default_permissions = ":workspace" is present without a [permissions] table.

What changed

  • Expose whether the merged config is explicitly in permission-profile mode.
  • Expose the configured custom permission profile IDs alongside the built-in profile semantics.
  • Add regression coverage for profile mode detection and custom profile metadata, including the default_permissions = ":workspace" case.
  • Update the thread-manager sample config literal to match the expanded config shape.

Stack

  1. This PR: config metadata needed by downstream permission-profile consumers.
  2. #22931: refresh active permission profiles through runtime/session/network state.
  3. #21559: switch /permissions to the profile-aware TUI picker.

Verification

  • cargo check -p codex-thread-manager-sample
  • cargo test -p codex-core default_permissions_can_select_builtin_profile_without_permissions_table
  • cargo test -p codex-core permissions_profiles_allow_direct_write_roots_outside_workspace_root

Co-authored-by: Codex noreply@openai.com
@viyatb-oai viyatb-oai force-pushed the codex/viyatb/profile-permissions-config branch from 7335c4a to a48a30d Compare May 18, 2026 17:57
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@viyatb-oai viyatb-oai merged commit 3009e23 into main May 19, 2026
31 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/profile-permissions-config branch May 19, 2026 06:26
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants