TUI: route elicitation responses to request thread#23241
Merged
Conversation
etraut-openai
changed the title
etraut-openai
changed the title
canvrno-oai
approved these changes
May 18, 2026
Contributor
canvrno-oai
left a comment
canvrno-oai
left a comment
There was a problem hiding this comment.
Tested with an MCP server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #21894.
When the TUI handles an MCP elicitation, the request payload already includes the thread that generated the elicitation.
ChatWidget::handle_elicitation_request_nowwas ignoring that value and using the currently visible chat thread instead. In a multi-session TUI, that can sendresolve_elicitationto an older visible thread rather than the session that owns the pending elicitation, producingelicitation request not foundand leaving the prompt unresolved.What changed
McpServerElicitationRequestParams.thread_idin the ChatWidget elicitation handler and use it for app-link, form, fallback approval, and auto-decline resolution paths.