Repository navigation
fix: improve Windows compatibility for CLI commands and sandbox - #261
Merged
Merged
Conversation
Signed-off-by: Alpha Diop <alphakhoss@gmail.com>
Signed-off-by: Alpha Diop <alphakhoss@gmail.com>
Collaborator
|
Looks great, ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows compatibility issues (#248)
This PR addresses the Windows compatibility issues reported in #248:
Fix sandbox initialization failure on Windows
getSandbox()to returnSandboxType.NONEon Windows instead of throwing an errorFix Unix commands not working on Windows
Testing
Tested on Windows 10 with the following commands:
ls -R .(now automatically translates todir /s .)grep,cat, etc.The CLI no longer crashes when running these commands on Windows.
I have read the CLA Document and I hereby sign the CLA